From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C06C77B61 for ; Fri, 14 Apr 2023 02:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbjDNC1p (ORCPT ); Thu, 13 Apr 2023 22:27:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjDNC1n (ORCPT ); Thu, 13 Apr 2023 22:27:43 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6907630D5 for ; Thu, 13 Apr 2023 19:27:42 -0700 (PDT) Received: from dggpemm500006.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PyKzN1lFDzKyTr; Fri, 14 Apr 2023 10:25:04 +0800 (CST) Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 14 Apr 2023 10:27:40 +0800 Subject: Re: [PATCH v5] arm64: kdump: simplify the reservation behaviour of crashkernel=,high To: Catalin Marinas , Baoquan He CC: , , , , , References: <20230407022419.19412-1-bhe@redhat.com> From: "Leizhen (ThunderTown)" Message-ID: <1ab19701-b72f-34f8-8feb-662a7dc59580@huawei.com> Date: Fri, 14 Apr 2023 10:27:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/4/13 22:30, Catalin Marinas wrote: > On Thu, Apr 13, 2023 at 03:45:50PM +0800, Baoquan He wrote: >> I am OK with this version, or the version with min(SZ_4G, >> arm64_dma_phys_limit), or v4. Please help point out if I got your idea >> correctly. Thanks a lot. > > I think we should stick to this patch. The disabling of the ZONE_DMA(32) > is fairly specialised and you are right that we should not introduce an > artificial 4GB crashkernel boundary on such systems. The slight > confusion may be that ,high triggers a search above 4GB where there's > not such boundary but this would match the documentation anyway. > Agreed, so careful. -- Regards, Zhen Lei