From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 324E3C433ED for ; Mon, 5 Apr 2021 20:37:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E435A613CC for ; Mon, 5 Apr 2021 20:37:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240952AbhDEUhl (ORCPT ); Mon, 5 Apr 2021 16:37:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237073AbhDEUhj (ORCPT ); Mon, 5 Apr 2021 16:37:39 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4FA2C061788; Mon, 5 Apr 2021 13:37:32 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id u5-20020a7bcb050000b029010e9316b9d5so6180435wmj.2; Mon, 05 Apr 2021 13:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=zSdJzo4zoszwh3Ropy9vcijZc4A27t1uaB8gJuuiu4g=; b=hmVYR+JY6euACjuRwMjEvkG0WrRGtN9CAFdInTC2M0Vl9ezJsRsiyqHtMXYe7kQmMO Yyk4bABlSI+X8WQmYS8WsbhxJiaRCZrXyTsu32jw0N4qO8M5lu0srht25bZJvJFAn2r5 JXqbnEChpJxkUohqQGqWEHBdchlFlpupZZB4jLmaWbO7+q+XgctquRjn+j8OaLkhMNAY Souxwwno2tEy0NrmCHzJ82ciFqmlF8SlfJWiXXZd+V/j5z7XI5IQO334BjUjml16yRQ4 9TYeflMTWDIjld/UXHbJwIZQeecU5leg3uJMZRf2IMf7nRzRYCkIbONYwEUwpxk9UvaZ r5cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zSdJzo4zoszwh3Ropy9vcijZc4A27t1uaB8gJuuiu4g=; b=JNAG63dgWW72qOfwRePELqqMA5EqWiSVL3fxevJETRmwhvAc/uVlSy1abIgUbRT3pf kEb5Q+nz2bKR/480/E2357tDMe2jD/7QGXHvcU7IiQKa59VXHKplE7V8aQrs9rQxOC57 x7xwt7PixdKQooCJyVHf9nbLw4bh5IfOuoGUrna7GttnRhVeiHlFuZ1uiSUzNkKxjrYk xxoHfs7OhQGonHCBZU0mZ0//cPWfP1urEk9T6BhdxhBoAnXbRPKlM86JLEwXGur8r2q1 7XpsVym74l7B0zP+/1SVy+nxGiKKNpoajqV07Go4c/Oeyc5l8l+0NRfSzKFggDb0ROxe 4aSQ== X-Gm-Message-State: AOAM533nbfg5MbvwLFAjkD5Nbg8DMKH0koDE9rwkYrypZjCpJrWxxIIQ U9OkN3NL6UMss7aEN9JPHj0= X-Google-Smtp-Source: ABdhPJxLvu1nDd41bm0vAQpJa/jWZ5c+AmGLkoqj2+wngMdm3FzMnHaMKgrH9TLW1Z+BZthq4sf80g== X-Received: by 2002:a05:600c:2947:: with SMTP id n7mr777816wmd.61.1617655051662; Mon, 05 Apr 2021 13:37:31 -0700 (PDT) Received: from [192.168.1.211] ([2.29.208.21]) by smtp.gmail.com with ESMTPSA id v3sm679284wmj.25.2021.04.05.13.37.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 13:37:31 -0700 (PDT) Subject: Re: [PATCH v1 1/1] media: ipu3-cio2: Fix referece counting when looping over ACPI devices To: Andy Shevchenko , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yong Zhi , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab References: <20210404181409.1451026-1-andy.shevchenko@gmail.com> From: Daniel Scally Message-ID: <1ab48622-be85-f1d7-caa4-8b04a4727d5d@gmail.com> Date: Mon, 5 Apr 2021 21:37:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210404181409.1451026-1-andy.shevchenko@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy On 04/04/2021 19:14, Andy Shevchenko wrote: > When we continue, due to device is disabled, loop we have to drop reference count. > When we have an array full of devices we have to also drop the reference count. > Note, in this case the cio2_bridge_unregister_sensors() is called by the caller. > > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver") > Cc: Daniel Scally > Cc: Sakari Ailus > Signed-off-by: Andy Shevchenko Ah; thanks for catching those, I'm annoyed to have missed the acpi_dev_put() calls in particular Reviewed-by: Daniel Scally