From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Paul Moses <p@1g4.org>, Ding Meng <meng.ding@siemens.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
florian.bezdeka@siemens.com, jan.kiszka@siemens.com,
wq.wang@siemens.com, Jason Xing <kerneljasonxing@gmail.com>,
Simon Horman <horms@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] net: mark skb NAPI IDs independently of busy polling
Date: Fri, 13 Nov 2026 21:59:17 +0100 [thread overview]
Message-ID: <1ab53072-b9ee-464b-b5b3-cbb578059b49@engleder-embedded.com> (raw)
In-Reply-To: <Fhn2gT70aJ-2_eak73NBZYuXuKtVb64PoD8VQ9jwm-S-K0RhZilAg9iwSBJ0RlaiSrRvM1vPw1aHvGPjcktu9GmdBuvFk9244-q2IVOrFu0=@1g4.org>
On 13.11.26 09:29, Paul Moses wrote:
>
>>
>> Then, drivers that use deferred timestamp conversion (e.g. igc, engleder) must
>> specify a busy poll dependency if they want to obtain the original net
>> device upon consuming the skb. However, this dependency is far from
>> obvious, and annotating it for future features of this kind will be very
>> hard to discover.
>
> The "deferred timestamp conversion" was incomplete is what I'm saying.
>
> This started with 97dc7cd92ac6, 0abb62b68252 and 069b142f5819 were built upon
> it, so maybe Gerhard should decide the path forward?
The deferred timestamp conversion is a niche feature for TSN to solve
the working clock / global time problem in TSN networks. IMO there is
no need to make it working as soon as igc or tsnep drivers are enabled.
It would be ok to fall back to normal vclock behavior like all other
drivers if CONFIG_NET_RX_BUSY_POLL=n. For me it is ok that NETCONSOLE
is not possible for PREEMPT_RT in combination with this feature.
There are already so many things to consider to get TSN working. To
not enable NETCONSOLE on PREEMPT_RT for deferred timestamp conversion
would be just one of many.
@Ding Meng: Do you actually need the NETCONSOLE in this combination?
On productive systems likely not these days due to CRA.
Gerhard
prev parent reply other threads:[~2026-11-13 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 7:16 Ding Meng
2026-11-05 8:04 ` bot+bpf-ci
2026-11-05 18:36 ` Jacob Keller
2026-11-05 22:29 ` Paul Moses
2026-11-06 2:03 ` Paul Moses
2026-11-06 5:50 ` Ding Meng
2026-11-06 6:36 ` Paul Moses
2026-11-10 19:32 ` Gerhard Engleder
2026-11-10 21:45 ` Jakub Kicinski
2026-11-12 4:33 ` Ding Meng
2026-11-13 8:29 ` Paul Moses
2026-11-13 20:59 ` Gerhard Engleder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ab53072-b9ee-464b-b5b3-cbb578059b49@engleder-embedded.com \
--to=gerhard@engleder-embedded.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=florian.bezdeka@siemens.com \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.kiszka@siemens.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=memxor@gmail.com \
--cc=meng.ding@siemens.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p@1g4.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=wq.wang@siemens.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®