From: Bart Van Assche <bvanassche@acm.org>
To: kensanya <kensanya@163.com>
Cc: jgg@ziepe.ca, leon@kernel.org, linux-rdma@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
TanZheng <tanzheng@kylinos.cn>
Subject: Re: [PATCH] RDMA/srpt: fix NULL deref when sending BUSY before target_init_cmd()
Date: Wed, 22 Jul 2026 11:10:13 -0700 [thread overview]
Message-ID: <1ab82159-e644-46ac-9af8-a482e2b0f951@acm.org> (raw)
In-Reply-To: <41ddb3a1.16d1.19f87866fa1.Coremail.kensanya@163.com>
On 7/21/26 6:52 PM, kensanya wrote:
> How about the following plan?
> - If target_init_cmd() fails:
> release the send ioctx locally via target_free_tag(ch->sess, cmd)
> and do not call target_send_busy()
> - If target_init_cmd() succeeds but a later step fails
> (e.g. srpt_get_desc_tbl()):
> keep using target_send_busy(cmd)
That sounds good to me.
Thanks,
Bart.
next prev parent reply other threads:[~2026-07-22 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 2:59 kensanya
2026-07-20 16:31 ` Bart Van Assche
2026-07-22 1:52 ` kensanya
2026-07-22 18:10 ` Bart Van Assche [this message]
2026-07-23 1:55 ` kensanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ab82159-e644-46ac-9af8-a482e2b0f951@acm.org \
--to=bvanassche@acm.org \
--cc=jgg@ziepe.ca \
--cc=kensanya@163.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tanzheng@kylinos.cn \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome