From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755691AbdBHBTs (ORCPT ); Tue, 7 Feb 2017 20:19:48 -0500 Received: from smtprelay4.synopsys.com ([198.182.47.9]:38918 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753568AbdBHBTr (ORCPT ); Tue, 7 Feb 2017 20:19:47 -0500 Subject: Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings To: Dan Carpenter , Carlos Palminha References: <20170208004722.26305-1-palminha@synopsys.com> <20170208005806.GF11154@mwanda> CC: , , From: Carlos Palminha Message-ID: <1abdb4fa-9161-2891-ded6-83763d678c2e@synopsys.com> Date: Wed, 8 Feb 2017 01:19:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170208005806.GF11154@mwanda> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.15.34] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-02-2017 00:58, Dan Carpenter wrote: > On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote: >> Fixed the following sparse warnings: >> * cast from restricted __le32 >> * invalid assignment from int to __le32 >> > > The changelog doesn't give me any confidence that you understand the > implications of this patch. You silenced the warning but I think you > may be introducing bugs (I haven't done a thourough review). > > regards, > dan carpenter > true... i was short on words. will resend v2 with better description. Regards, C.Palminha