From: "Zhi Mao (毛智)" <zhi.mao@mediatek.com>
To: "mchehab@kernel.org" <mchehab@kernel.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>
Cc: "heiko@sntech.de" <heiko@sntech.de>,
"gerald.loacker@wolfvision.net" <gerald.loacker@wolfvision.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yunkec@chromium.org" <yunkec@chromium.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"dan.scally@ideasonboard.com" <dan.scally@ideasonboard.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"Shengnan Wang (王圣男)" <shengnan.wang@mediatek.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"Yaya Chang (張雅清)" <Yaya.Chang@mediatek.com>,
"bingbu.cao@intel.com" <bingbu.cao@intel.com>,
"jacopo.mondi@ideasonboard.com" <jacopo.mondi@ideasonboard.com>,
"jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"10572168@qq.com" <10572168@qq.com>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"tomi.valkeinen@ideasonboard.com"
<tomi.valkeinen@ideasonboard.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"macromorgan@hotmail.com" <macromorgan@hotmail.com>
Subject: Re: [PATCH v3 1/2] media: dt-bindings: media: i2c: Document GC08A3 bindings
Date: Sun, 4 Feb 2024 06:34:41 +0000 [thread overview]
Message-ID: <1abe92bbe6e93f119a735e41dfdc0eac7f0a5080.camel@mediatek.com> (raw)
In-Reply-To: <7dbe0235-43f3-4060-b7ac-4c429c5aff4e@linaro.org>
Hi Krzysztof,
Thanks for your review.
On Tue, 2024-01-09 at 10:24 +0100, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 09/01/2024 03:27, Zhi Mao wrote:
> > Add YAML device tree binding for GC08A3 CMOS image sensor,
> > and the relevant MAINTAINERS entries.
> >
>
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
>
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> Subject: only one "media", so:
> media: dt-bindings: i2c: add GalaxyCore GC08A3 image sensor
>
fixed in patch:v4.
> > Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
>
> ...
>
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + sensor0@31 {
>
> sensor@31
>
> With above fixed:
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
fixed in patch:v4.
> Before you reply, fix your email client. It's impossible to read your
> responses.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-02-04 6:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 2:27 [PATCH v3 0/2] media: i2c: Add support for GC08A3 sensor Zhi Mao
2024-01-09 2:27 ` [PATCH v3 1/2] media: dt-bindings: media: i2c: Document GC08A3 bindings Zhi Mao
2024-01-09 9:24 ` Krzysztof Kozlowski
2024-02-04 6:34 ` Zhi Mao (毛智) [this message]
2024-01-09 2:27 ` [PATCH v3 2/2] media: i2c: Add GC08A3 image sensor driver Zhi Mao
2024-01-09 10:18 ` Sakari Ailus
2024-01-25 2:24 ` Zhi Mao (毛智)
2024-01-25 16:01 ` sakari.ailus
2024-02-04 6:38 ` Zhi Mao (毛智)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1abe92bbe6e93f119a735e41dfdc0eac7f0a5080.camel@mediatek.com \
--to=zhi.mao@mediatek.com \
--cc=10572168@qq.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Yaya.Chang@mediatek.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bingbu.cao@intel.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yunkec@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®