From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: NXP Linux Team <linux-imx@nxp.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Adam Ford <aford173@gmail.com>,
Shengjiu Wang <shengjiu.wang@freescale.com>
Subject: effect of multiple spba bus nodes
Date: Fri, 31 May 2024 12:07:36 +0200 [thread overview]
Message-ID: <1abeef45-df5f-4779-86e1-b89f179ccd0c@prevas.dk> (raw)
[resending because I never got a reply]
So commit 9424e7f064055 (arm64: dts: imx8mp: Enable spba-bus on AIPS3)
caused us a little trouble [*], but I got curious and tried figuring out
what effect wrapping those nodes in an spba-bus node actually had.
Grepping for the compatible string, one finds
Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml which says
It is an extension of
"simple-bus" because the SDMA controller uses this compatible flag to
determine which peripherals are available to it and the range over
which the SDMA can access.
OK. The one and only place in .c files where that compatible is
mentioned is in drivers/dma/imx-sdma.c, which does
of_find_compatible_node(NULL, NULL, "fsl,spba-bus");
which I suppose just returns some random (well, not random, just the
first in DT) node. Many .dtsi files, e.g. the imx8mp.dtsi as case in
point, have more than one spba-bus, so how does that work?
Rasmus
[*] We assign stable netdev names based on the full path to the device's
DT node, but that logic broke when the CAN devices got new DT paths. I'm
not disputing the correctness of 9424e7f064055, we've adapted on our end.
reply other threads:[~2024-05-31 10:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1abeef45-df5f-4779-86e1-b89f179ccd0c@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=aford173@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®