mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kenneth Sloat <ksloat@designlinxhs.com>
To: "hyun.kwon@xilinx.com" <hyun.kwon@xilinx.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Cc: "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"laurent.pinchart@ideasonboard.com" 
	<laurent.pinchart@ideasonboard.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>
Subject: dt-bindings: display: xlnx: mixer: Inconsistent pixel format terminology in dt docs
Date: Thu, 20 Aug 2020 21:17:46 +0000	[thread overview]
Message-ID: <1ac0eeed-7455-b0a3-a3e4-4501ae3129df@designlinxhs.com> (raw)

Hello,

The Xilinx Video mixer IP uses the DRM fourcc string as a device tree binding in order to describe the format for a specific DRM layer/plane. Currently, in the device tree doc in "Documentation/devicetree/bindings/dma/xilinx/xilinx_frmbuf.txt" there is a list called "VIDEO FORMATS" with a table containing "Mixer IP Format" and associated "Driver supported Format String" (fourcc). In general, this table is not helpful, because "Mixer IP Format" does not match the Xilinx IP datasheet terminology for formats but rather some other commonly used nomenclature. This is also inconsistent from other Xilinx dts binding docs which specify the actual correct IP name and at times list other format nomenclature where helpful (i.e. xilinx_frmbuf.txt)

My suggestion is to remove the current "Mixer IP Format" strings in the doc and replace them with the actual IP names in the datasheet (which also match those used in Xilinx's Vivado FPGA tool). Otherwise, the programmer must cross reference other dts documentation or the code in order to figure these out. I am happy to provide a patch for this but wanted to throw out the suggestion first.

Thanks

Sincerely,
Ken Sloat


             reply	other threads:[~2020-08-20 21:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 21:17 Kenneth Sloat [this message]
2020-08-20 23:38 ` Hyun Kwon
2020-08-23 23:17   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ac0eeed-7455-b0a3-a3e4-4501ae3129df@designlinxhs.com \
    --to=ksloat@designlinxhs.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hyun.kwon@xilinx.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®