mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Willy Tarreau" <w@1wt.eu>
Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: [PATCH v2 2/4] parisc: Makefile: use the regular compiler to build a native 32-bit vDSO
Date: Wed, 8 Apr 2026 21:01:45 +0200	[thread overview]
Message-ID: <1ac41118-471e-44a9-bf2c-f727ec5ded42@gmx.de> (raw)
In-Reply-To: <20260408-nolibc-hppa-v2-2-7fe404cb61e3@weissschuh.net>

Hi Thomas,

On 4/8/26 20:18, Thomas Weißschuh wrote:
> When building a native 32-bit kernel $(CC) the compiler is obviously
> able to compile 32-bit code. There is no need to force the user to
> configure a dedicated 32-bit compiler.

I'm not sure, but still I think this logic of your patches #1 and #2
may break the builds for others.
That said, I'd prefer if we can get it working without your patches #1 and #2.
Can't we do without them?

I tried your patch series, but they fail to apply to my series or
upstream.

Helge


> 
> Use the regular compiler for the 32-bit vDSO when it is sufficient.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>   arch/parisc/Makefile | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 92b769f4bbe7..ab8a93e773fb 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -49,6 +49,7 @@ ifdef cross_compiling
>       endif
>   endif
>   
> +ifdef CONFIG_64BIT
>   # Set default 32 bits cross compilers for vdso.
>   # This means that for 64BIT, both the 64-bit tools and the 32-bit tools
>   # need to be in the path.
> @@ -58,6 +59,9 @@ CROSS32_COMPILE := $(call cc-cross-prefix, \
>   	$(foreach a,$(CC_ARCHES_32), \
>   	$(foreach s,$(CC_SUFFIXES),$(a)-$(s)-)))
>   CROSS32CC := $(CROSS32_COMPILE)gcc
> +else
> +CROSS32CC := $(CC)
> +endif
>   export CROSS32CC
>   
>   ifdef CONFIG_DYNAMIC_FTRACE
> 


  reply	other threads:[~2026-04-08 19:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 18:18 [PATCH v2 0/4] tools/nolibc: add support for 32-bit parisc Thomas Weißschuh
2026-04-08 18:18 ` [PATCH v2 1/4] parisc: Makefile: move CROSS_COMPILE detection before CROSS32CC one Thomas Weißschuh
2026-04-08 18:18 ` [PATCH v2 2/4] parisc: Makefile: use the regular compiler to build a native 32-bit vDSO Thomas Weißschuh
2026-04-08 19:01   ` Helge Deller [this message]
2026-04-08 19:42     ` Thomas Weißschuh
2026-04-08 20:52       ` Helge Deller
2026-04-08 21:00         ` Thomas Weißschuh
2026-04-08 18:18 ` [PATCH v2 3/4] selftests/nolibc: avoid function pointer comparisons Thomas Weißschuh
2026-04-08 18:18 ` [PATCH v2 4/4] tools/nolibc: add support for 32-bit parisc Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ac41118-471e-44a9-bf2c-f727ec5ded42@gmx.de \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®