From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FBA920E035 for ; Fri, 10 Jan 2025 15:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736522946; cv=none; b=QtGGYtzQuxo/kBVcIJxOvYsvbcBP6CADXQT4OcyT+9QmBTScrdmUH+XLNnN8mEOe44oRsve1UvcLpQckSV67HNEwLd0kvnW2668mafAMML1lEFMPDLw12GgWl8hBhOm09kXTVI306FtVyWuI+sui0KmMWgTg220PGjmRmY9uleo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736522946; c=relaxed/simple; bh=ONFk/iX6hSegNSzb3FKu5rFfjM+kOjWnXrEQU9/+pC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MTVruLA2BPcuiKQ+LSQxxbn9VO1FNmKn8sc5n1mUH7ksB4oDHatqKdMfmNMSFbV/2WL7/bppM0wxGqYaca4qfaBSSOZ84EAn8wIURJ7hiMed6pRVi5YdfQMDIx0RonEVj6zUVwPXAup/RyBNb/xXN8UOOcMqYCA9h6ifseoFIXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dGJrmNRi; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dGJrmNRi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736522944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JedACyF3qaYIJ70J/2rldT4MFWaos417O6C0UzElWMQ=; b=dGJrmNRij8aOAk4y79Mkack8DOXaDQC9B+DF4Tfm1XretkqwJnqK4yWxK9Ro01gxygGhQY OuDDY4p32tP/ppsm9nAKJjUa9rCx1Bcwz3LDIDJUCMt6jjvZI/djJKnBsETSCQzIJVfgPw CINDwGOvaAXATMbubPNZVasYpSzdQjo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-ejFIfVlkO2WXxpCR8XVZTA-1; Fri, 10 Jan 2025 10:29:02 -0500 X-MC-Unique: ejFIfVlkO2WXxpCR8XVZTA-1 X-Mimecast-MFC-AGG-ID: ejFIfVlkO2WXxpCR8XVZTA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361fc2b2d6so12087805e9.3 for ; Fri, 10 Jan 2025 07:29:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736522941; x=1737127741; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JedACyF3qaYIJ70J/2rldT4MFWaos417O6C0UzElWMQ=; b=txWaNhZkm4RZtTpaNBc+zh74OpGIi9I1AOciAH8M/2XQs+5N1WPPLQXll6bnqd6cTy iGgxgatb/rTI8QFPzCYchiMTyEv1BmnU/qj32mn3tPv10gUxJSIi3lY+twD+Wux10uCl SV5ix0iHke3dZ3q9WXaLmeBpua7IAGiIIX7N0XhfYAn5BEb6oyzTNZys7BUX11U+QHcI ClzZ0bplP+2LD41FbMFBYdm0omBFHBnCYeHwGfn/piTAfDC2KNKgGOedPfxFLjgOSQBg amhDK2PNtLDZkG98lJvbug4qkn0w1na50PwmJJ9mrAr+r2a4tDdBOS96DBC19Qql/sPv h+Rw== X-Forwarded-Encrypted: i=1; AJvYcCVD+bpgsUOPmcAp6hxizA6rqTaSIs03ibSTam5jMQUPsFgKycxHjjL+A1vesFaCBdgIgc7LNrhcpSajsOY=@vger.kernel.org X-Gm-Message-State: AOJu0Yww89EUFlRT8HRApZnDbjlI+bgBf2nd8+hbpfMQtZnUiNZAbx2i lCASDtkr3mIYC5w5DviCz8iGIPgyO3Unp6E/7MP0bI9T5qMTs/6X442jMTa2aPJXz0344B4ERKd tJSc80WFAMkCDBdSFd0XSk3hsgigsmc9RbjENLuAQo9MdG1koWeujQYF73feGzQ== X-Gm-Gg: ASbGncv6K6YBsZKY5OuEQQxEMyoz0fKKj221MemPrx7Ut9KP+w2n6FjuUIeTHtzqKTW qmAOp1aVrSGi13rYBRa5zd+s179aDDXaMeHeORS+BE00C280dp87vMZavAfTVP8ZAmpmtoulUZH qkc2niY9iXMFGKzwwjmYkmvsH6f/L9FRW9Z80tQuyaCt9/JfKrrxyx62MSM3X76YZWbND4EWERK 8sEWW5ENOXYiHQ7iRm+yJOZYJsDE1aNfqlPpm9CmDGkW5oHvYaWPabZSSH1JrsrtziGCp1w+CwG fZ9s3GH/C2mMoml3IWFms03B3vZonDieethnhalffbZcriCldxfKrc6UolgaHa5E6S60jx3Xn2K 363sMHtwq X-Received: by 2002:a05:600c:46c6:b0:436:5165:f21f with SMTP id 5b1f17b1804b1-436e26d9482mr94059645e9.26.1736522940998; Fri, 10 Jan 2025 07:29:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnAGe2xqHxmg2z1ZugKda1zemeP3ZymZ6IqA3Yc14/9MbHhyrmu+3BSz6AZa88PuYXrh1Cow== X-Received: by 2002:a05:600c:46c6:b0:436:5165:f21f with SMTP id 5b1f17b1804b1-436e26d9482mr94058915e9.26.1736522939414; Fri, 10 Jan 2025 07:28:59 -0800 (PST) Received: from ?IPV6:2003:cb:c708:e100:4f41:ff29:a59f:8c7a? (p200300cbc708e1004f41ff29a59f8c7a.dip0.t-ipconnect.de. [2003:cb:c708:e100:4f41:ff29:a59f:8c7a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4c1ce5sm4865805f8f.94.2025.01.10.07.28.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 07:28:57 -0800 (PST) Message-ID: <1ac669c9-331b-493c-a241-8a7a07716eed@redhat.com> Date: Fri, 10 Jan 2025 16:28:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] selftests/mm: virtual_address_range: mmap() without PROT_WRITE To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Andrew Morton , Shuah Khan , Dev Jain , Thomas Gleixner Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250110-virtual_address_range-tests-v2-0-262a2bf3c3d0@linutronix.de> <20250110-virtual_address_range-tests-v2-1-262a2bf3c3d0@linutronix.de> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250110-virtual_address_range-tests-v2-1-262a2bf3c3d0@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10.01.25 14:05, Thomas Weißschuh wrote: > When mapping a larger chunk than physical memory is available with > PROT_WRITE and overcommit is disabled, the mapping will fail. > This will prevent the test from running on systems with less then ~1GiB > of memory and triggering an inscrutinable test failure. > As the mappings are never written to anyways, the flag can be removed. > > Fixes: 010409649885 ("selftests/mm: confirm VA exhaustion without reliance on correctness of mmap()") > Signed-off-by: Thomas Weißschuh > > --- > I went with dropping PROT_WRITE instead of adding MAP_NORESERVE as this > works even in the face of OVERCOMMIT_NEVER. Yes, makes sense, it's certainly simpler this way. Acked-by: David Hildenbrand -- Cheers, David / dhildenb