From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=203.254.224.24 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793015862; b=WEzZFyXPS4JGI7xpz+EwPUqGT1hii1sYOJVMWfImGRnZ+5dqUlFJ6YkhuwvgOErFlPu8 82iPMT8ni8NpvCwEd01j2s9Fl/yvkpC86fI7ZzU34Rp68i5tuedSPXB9lfCkyw1LxmGrh q9E7X0rBvfyu1ahTu7vC+kbD8dKCdgW6kIAYW02ito9POWxjpJ0bfnnxYUHLR+NpJtDZ7 T422BmRQOtR757pNFuKi0jvNbTz6Br3fKC+bqXiBZkwxse2mqpLpJhJZ+A9ZPUVjgyYW4 obnj+5o4aSvQmwGxDmWAD58q/ERtkucFfjwZVq7SgYjoenD/6qTf/hB01dTPTwNENhA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793015862; h=DMARC-Filter:Received:DKIM-Filter:DKIM-Signature:Received:Received: Received:Received:Message-ID:Date:MIME-Version:User-Agent:Subject:To: Cc:Content-Language:From:In-Reply-To:Content-Transfer-Encoding: X-CMS-MailID:X-Msg-Generator:Content-Type:CMS-TYPE:cpgsPolicy: X-CFilter-Loop:X-CMS-RootMailID:References; bh=8yn+f7/xPBR45GbhMRQUjqpcIdGoRih5Xrmg69vMj9I=; b=QFizuL24tPfaCongG8f1vhfZwoSuuIbJMFgOsEegAFBNsCVP5S/6HS/uvmKbq4UtXGcZ WpycFikxKrmUku3hJRYdWcSPlFcDTRLrPxBtU5sls3/ieLC9PuzkWP6IroTExvFp80DmF ZKw2+xQ+lcNgqpTaGrGfPkVhqs4P0BOAXCwymZqHoFBFbShGfyLpDqJiDs0+bKUB3nbt8 jpX4YazGVZTeCaVFEoEffCclYx0FdrrbVNSDnRpd+qOci+UZ817et+4mkoLij3nhMTgsu 1koLP4tlbXVaNx/C1Xper/MbkM09vfmym80ue22HSmOWJCRMNhHp3HWgWVm40wmw+LQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=dFtkNSjz; arc=none smtp.remote-ip=203.254.224.24 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7776606A31A for ; Mon, 26 Oct 2026 11:57:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A7776606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=dFtkNSjz Received: from epcas5p2.samsung.com (unknown [182.195.41.40]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20261026115739epoutp01229becc713f6434340125dd40cb67988~iEmynM5UU3239932399epoutp01w for ; Mon, 26 Oct 2026 11:57:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20261026115739epoutp01229becc713f6434340125dd40cb67988~iEmynM5UU3239932399epoutp01w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1793015859; bh=8yn+f7/xPBR45GbhMRQUjqpcIdGoRih5Xrmg69vMj9I=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=dFtkNSjzbIAbdXMTmo3EcYT8iyToFI0EBPZkBeG3uzAx4RsVzmUC9pPsmWingxIQu Ji1FRqAL0f/NPoPuxh2t9CvHIUURD2hkoc0uRwBzg97dnjxJiaJ/rGxej3skOanJFv Y3qVFvWUvTJN5XVh2bquDaDfpzuMUE/sMrRp0mbY= Received: from epsnrtp04.localdomain (unknown [182.195.42.156]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPS id 20261026115738epcas5p18b2bcee968bbbf08476340af7da6ef1e~iEmxllekR1444514445epcas5p12; Mon, 26 Oct 2026 11:57:38 +0000 (GMT) Received: from epcas5p1.samsung.com (unknown [182.195.38.93]) by epsnrtp04.localdomain (Postfix) with ESMTP id 4jCsZ936YGz6B9m9; Mon, 26 Oct 2026 11:57:37 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20261026115736epcas5p399ee58609e8a2d9584fcd86dc1e5b852~iEmwPv0sJ0063700637epcas5p3T; Mon, 26 Oct 2026 11:57:36 +0000 (GMT) Received: from [107.122.5.126] (unknown [107.122.5.126]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20261026115733epsmtip16c43d131d64fca287f1f0c2545ded44a~iEmtNzYCi0993709937epsmtip1t; Mon, 26 Oct 2026 11:57:33 +0000 (GMT) Message-ID: <1acd29ba-c9db-45e3-b7c4-49bf8f8a14b9@samsung.com> Date: Mon, 26 Oct 2026 17:27:32 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: usb: Add Samsung Exynos8855 DWC3 controller binding To: Krzysztof Kozlowski Cc: gregkh@linuxfoundation.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, peter.griffin@linaro.org, alim.akhtar@samsung.com, Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, jh0801.jung@samsung.com, h10.kim@samsung.com, dh10.jung@samsung.com, akash.m5@samsung.com, hongpooh.kim@samsung.com, eomji.oh@samsung.com, shijie.cai@samsung.com, muhammed.ali@samsung.com, thiagu.r@samsung.com Content-Language: en-US From: Selvarasu Ganesan In-Reply-To: <20261026-talented-wolf-of-karma-8abbbd@quoll> Content-Transfer-Encoding: 8bit X-CMS-MailID: 20261026115736epcas5p399ee58609e8a2d9584fcd86dc1e5b852 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P cpgsPolicy: CPGSC10-542,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20261023131545epcas5p1eff195129ccfb0fb476d3c78e6a507bc References: <20261023131501.3157463-1-selvarasu.g@samsung.com> <20261023131501.3157463-2-selvarasu.g@samsung.com> <20261026-talented-wolf-of-karma-8abbbd@quoll> On 10/26/2026 3:14 PM, Krzysztof Kozlowski wrote: > On Fri, Oct 23, 2026 at 06:45:00PM +0530, Selvarasu Ganesan wrote: >> +title: Samsung Exynos8855 DWC3 USB controller >> + >> +maintainers: >> + - Krzysztof Kozlowski >> + - Selvarasu Ganesan >> + >> +description: >> + Describes the DWC3 USB controller block implemented on the Samsung >> + Exynos8855 SoC. >> + >> +properties: >> + compatible: >> + enum: >> + - samsung,exynos8855-dwc3 >> + >> + reg: >> + maxItems: 1 >> + >> + power-domains: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 > interrupts go after clocks, power-domains after interrupts. Hi Krzysztof, Thanks for your comments. My bad, will update in the next version. > >> + >> + clocks: >> + description: | >> + Two clocks are used: >> + - ref: Reference clock for SOF/ITP generation. >> + - bus: Bus (APB) clock for register access. >> + minItems: 2 >> + maxItems: 2 > Instead replace all this with listing items with description. Don't > repeat constraints in free form text. > > items: > - description: > - description: Sure, will update the clocks as below in the next version,     clocks:       items:         - description: Reference clock for SOF/ITP generation.         - description: Bus (APB) clock for register access. Thanks, Selva >> + >> + clock-names: >> + items: >> + - const: ref >> + - const: bus >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - interrupts > Here you have correct order. > > Best regards, > Krzysztof