From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932622AbeARTA0 (ORCPT ); Thu, 18 Jan 2018 14:00:26 -0500 Received: from vern.gendns.com ([206.190.152.46]:53781 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754513AbeARTAY (ORCPT ); Thu, 18 Jan 2018 14:00:24 -0500 Subject: Re: [PATCH v5 20/44] dt-bindings: clock: Add bindings for TI DA8XX USB PHY clocks To: Sekhar Nori , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , Adam Ford , linux-kernel@vger.kernel.org References: <1515377863-20358-1-git-send-email-david@lechnology.com> <1515377863-20358-21-git-send-email-david@lechnology.com> <33f0feba-adee-e365-54d5-16fe3d49302d@ti.com> From: David Lechner Message-ID: <1acdc3cf-f08b-3476-e656-5dc25103e86d@lechnology.com> Date: Thu, 18 Jan 2018 13:00:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <33f0feba-adee-e365-54d5-16fe3d49302d@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18/2018 06:10 AM, Sekhar Nori wrote: > On Monday 08 January 2018 07:47 AM, David Lechner wrote: >> This adds a new binding for TI DA8XX USB PHY clocks. These clocks are part >> of a syscon register called CFGCHIP3. > > CFGCHIP2 > >> >> Signed-off-by: David Lechner > >> +Examples: >> + >> + cfgchip: syscon@1417c { >> + compatible = "ti,da830-cfgchip", "syscon", "simple-mfd"; >> + reg = <0x1417c 0x14>; >> + >> + usb0_phy_clk: usb0-phy-clock { >> + compatible = "ti,da830-usb0-phy-clock"; >> + #clock-cells = <0>; >> + clocks = <&usb_refclkin>, <&pll0_aux_clk>, <&psc1 1>; >> + clock-names = "usb_refclkin", "auxclk", "usb0_lpsc"; >> + clock-output-names = "usb0_phy_clk"; > > Probably call this "usb0_phy" to match with the input name used for > usb1_phy_clk? I was planning on just dropping clock-output-names altogether actually since they don't really do anything useful. Also, I was considering sending a series to change the con_id for the PHY clocks. My current revision of the device tree bindings is looking like this: usb_phy: usb-phy { compatible = "ti,da830-usb-phy"; #phy-cells = <1>; clocks = <&usb_phy_clk 0>, <&usb_phy_clk 1>; clock-names = "usb20_phy", "usb11_phy"; status = "disabled"; }; usb_phy_clk: usb-phy-clocks { compatible = "ti,da830-usb-phy-clocks"; #clock-cells = <1>; clocks = <&psc1 1>, <&usb_refclkin>, <&pll0_auxclk>; clock-names = "fck", "usb_refclkin", "auxclk"; }; The clock-names = "usb20_phy", "usb11_phy" comes from the existing con_ids in the PHY driver's clk_get()s. However, in device tree, we are usually referring to the USB devices as usb0 and usb1 instead of usb20 and usb11, respectively. Figure 6-2 "USB Clocking Diagram" in spruh82c.pdf (AM1808 TRM) calls these clocks "CLK48" and "CLK48MHz from USB 2.0 PHY", so I was thinking of changing the con_ids (and therefore also clock-names) to "usb0_clk48" and "usb1_clk48".