From: Aradhya Bhatia <a-bhatia1@ti.com>
To: Jai Luthra <j-luthra@ti.com>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devarsht@ti.com>
Subject: Re: [PATCH v2 3/6] arm64: dts: ti: k3-am62a7-sk: Drop i2c-1 to 100Khz
Date: Tue, 3 Oct 2023 10:54:12 +0530 [thread overview]
Message-ID: <1ad3087c-c9aa-9a67-46c7-4969c97041d8@ti.com> (raw)
In-Reply-To: <20230928-mcasp_am62a-v2-3-ce9f0e1ba22b@ti.com>
On 28-Sep-23 14:54, Jai Luthra wrote:
> The TLV320AIC3106 audio codec is interfaced on the i2c-1 bus. With the
> default rate of 400Khz the i2c register writes fail to sync:
>
> [ 36.026387] tlv320aic3x 1-001b: Unable to sync registers 0x16-0x16. -110
> [ 38.101130] omap_i2c 20010000.i2c: controller timed out
>
> Dropping the rate to 100Khz fixes the issue.
>
> Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
Since the codec wouldn't have worked with the 400KHz, the initial DT
configuration is wrong, which makes this patch a fix, and should be
indicated as such.
With the Fixes tag added,
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
Regards
Aradhya
> ---
> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index c689d3da2def..866b2725f775 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -261,7 +261,7 @@ &main_i2c1 {
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&main_i2c1_pins_default>;
> - clock-frequency = <400000>;
> + clock-frequency = <100000>;
>
> exp1: gpio@22 {
> compatible = "ti,tca6424";
>
next prev parent reply other threads:[~2023-10-03 5:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 9:24 [PATCH v2 0/6] arm64: ti: Enable audio on AM62A Jai Luthra
2023-09-28 9:24 ` [PATCH v2 1/6] arm64: dts: ti: k3-am62a-main: Add nodes for McASP Jai Luthra
2023-09-28 9:24 ` [PATCH v2 2/6] arm64: dts: ti: k3-am62a7-sk: Split vcc_3v3 regulators Jai Luthra
2023-09-28 9:24 ` [PATCH v2 3/6] arm64: dts: ti: k3-am62a7-sk: Drop i2c-1 to 100Khz Jai Luthra
2023-10-03 5:24 ` Aradhya Bhatia [this message]
2023-10-03 8:02 ` Jai Luthra
2023-09-28 9:24 ` [PATCH v2 4/6] arm64: dts: ti: k3-am62a7-sk: Add support for TPS6593 PMIC Jai Luthra
2023-09-28 9:24 ` [PATCH v2 5/6] arm64: dts: ti: k3-am62a7-sk: Enable audio on AM62A Jai Luthra
2023-10-03 6:20 ` Vignesh Raghavendra
2023-09-28 9:24 ` [PATCH v2 6/6] arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ad3087c-c9aa-9a67-46c7-4969c97041d8@ti.com \
--to=a-bhatia1@ti.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-luthra@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®