From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B04E1C4CECD for ; Tue, 17 Sep 2019 06:18:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CBA920678 for ; Tue, 17 Sep 2019 06:18:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404118AbfIQGS2 (ORCPT ); Tue, 17 Sep 2019 02:18:28 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:48856 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730533AbfIQGS2 (ORCPT ); Tue, 17 Sep 2019 02:18:28 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 5E241D42291E0B16F045; Tue, 17 Sep 2019 14:18:25 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 14:18:23 +0800 Subject: Re: [PATCH] f2fs: add a condition to detect overflow in f2fs_ioc_gc_range() To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1568695763-29343-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: <1ad336ce-a28a-9841-6438-2b0f851c0a6f@huawei.com> Date: Tue, 17 Sep 2019 14:18:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1568695763-29343-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/9/17 12:49, Sahitya Tummala wrote: > end = range.start + range.len; > > If the range.start/range.len is a very large value, then end can overflow > in this operation. It results into a crash in get_valid_blocks() when > accessing the invalid range.start segno. > > This issue is reported in ioctl fuzz testing. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks,