From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbcGUKSP (ORCPT ); Thu, 21 Jul 2016 06:18:15 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:60560 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbcGUKSM (ORCPT ); Thu, 21 Jul 2016 06:18:12 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: frank.wang@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v8 3/3] arm64: dts: rockchip: add usb2-phy support for rk3399 To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Doug Anderson References: <1468913311-23977-1-git-send-email-frank.wang@rock-chips.com> <3513562.kdo4J8AU27@diego> Cc: Guenter Roeck , Guenter Roeck , Julius Werner , Kishon Vijay Abraham I , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-usb@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Ziyuan Xu , Kever Yang , Tao Huang , =?UTF-8?B?5ZC06Imv5bOw?= , daniel.meng@rock-chips.com, frank.wang@rock-chips.com From: Frank Wang Message-ID: <1ada0c16-9fd8-75b2-6357-1398073ac462@rock-chips.com> Date: Thu, 21 Jul 2016 18:17:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <3513562.kdo4J8AU27@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 2016/7/21 17:26, Heiko Stübner wrote: > Hi Frank, > > Am Donnerstag, 21. Juli 2016, 10:49:53 schrieb Frank Wang: >>>> @@ -69,6 +69,15 @@ >>>> >>>> regulator-max-microvolt = <3300000>; >>>> >>>> }; >>>> >>>> + vbus_host: vbus-host-regulator { >>>> + compatible = "regulator-fixed"; >>>> + enable-active-high; >>>> + gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>; >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 = <&host_vbus_drv>; >>>> + regulator-name = "vbus_host"; >>>> + }; >>>> + >>> To match my schematics, this would probably be "vcc5v0_host". >>> Technically there are two regulators but since they are the same >>> voltage and enabled by the same GPIO it seems like modeling it as one >>> regulator is fine. >> Yep, you are right, I will rename it. >> >>> If you really wanted to model things you could also include the input >>> supply (VCC5V0_SYS). Not sure how much you care to model in EVB. >> Actually, from >> "Documentation/devicetree/bindings/regulator/fixed-regulator.txt" show, >> input supply name is just optional property, and it seems that only do >> assign "vin" value for input_supply (the second member of struct >> fixed_voltage_config) if "vin-supply" is specified. >> >> So is input supply name (VCC5V0_SYS) required here? Would you like to >> give more comments please? > While vin-supply is optional, I think that is meant for real top-level > regulators (our vcc_sys or whatever) that really don't have a parent > regulator. > > It is always nicer to model the whole power-tree [in a sane way], as it makes > following the schematics a lot easier. If you mount a debugfs these days you > can even get a nice tree graph of the regulator infrastructure ... where the > parent-relationship is also needed to create something meaningful. > Got it, many thanks for your explanation, I will add vin-supply next version. BR. Frank > Heiko > > >