From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Md Danish Anwar <a0501179@ti.com>,
Conor Dooley <conor@kernel.org>,
MD Danish Anwar <danishanwar@ti.com>
Cc: Suman Anna <s-anna@ti.com>, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, vigneshr@ti.com,
srk@ti.com, nm@ti.com
Subject: Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property
Date: Tue, 8 Aug 2023 12:18:12 +0200 [thread overview]
Message-ID: <1ade44f5-b3d1-dcde-6819-9e944f3b115d@linaro.org> (raw)
In-Reply-To: <910a4a98-712a-5517-5a5b-ffb962f83463@ti.com>
On 08/08/2023 11:44, Md Danish Anwar wrote:
>>> properties:
>>> compatible:
>>> @@ -171,6 +181,9 @@ examples:
>>> <0x22400 0x100>;
>>> reg-names = "iram", "control", "debug";
>>> firmware-name = "am65x-pru0_0-fw";
>>> + interrupt-parent = <&icssg0_intc>;
>>> + interrupts = <16 2 2>;
>>> + interrupt-names = "vring";
>>> };
>>
>> These examples would probably be more helpful if they used the
>> appropriate defines, no?
>>
>
> PRUSS Interrupt controller doesn't have any appropriate defines. This doesn't
> use GIC so defines from arm-gic.h can not be used here. These are specific to
> PRUSS INTC.
>
> I think these example are OK. Please let me know if this is OK to you.
But isn't "2" type of the interrupt?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-08 16:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 11:08 MD Danish Anwar
2023-08-07 14:39 ` Conor Dooley
2023-08-08 9:44 ` Md Danish Anwar
2023-08-08 10:18 ` Krzysztof Kozlowski [this message]
2023-08-08 10:57 ` Md Danish Anwar
2023-08-08 14:53 ` Krzysztof Kozlowski
2023-08-08 10:48 ` Conor Dooley
2023-08-08 11:00 ` Md Danish Anwar
2023-08-08 11:28 ` Conor Dooley
2023-08-08 12:52 ` Md Danish Anwar
2023-08-11 11:18 ` Md Danish Anwar
2023-08-11 15:21 ` Conor Dooley
2023-08-14 5:13 ` Md Danish Anwar
2023-08-14 6:59 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ade44f5-b3d1-dcde-6819-9e944f3b115d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a0501179@ti.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®