From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789513054EF for ; Mon, 10 Aug 2026 13:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786369621; cv=none; b=nOoyTC0U8wwYAk5qbGO5pcer2pisfFB6NvCWyBb08DOs8JsdGhcAiEQPcYsEWV2ZUQQaVmlF+cDoLi3DdLC602TISJowUjcfNqgqlpOeAnsc2hkNtghpnzSVYZ3PUpmByFG+S+RUeTHl8Qc0MpcSzLbc0TZUPvabONaAh0MOYS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786369621; c=relaxed/simple; bh=nGvLBkBDKOaRJg4kSHLzaeM3hbIwICruJFemXkd3omU=; h=Message-ID:Subject:From:To:Cc:In-Reply-To:References:Content-Type: Date:MIME-Version; b=C5IwfOdMD/mflaa0rzKOO59FBr0CHTnBIIsydfAp/Cq9daCdcq4fXU+NbercBp0Xz19pE6WTQt2WogiFmY3Vlo2y+ZziM0XSc6b9QxTkMQ1AjCJtt8FGimEVydYlJUpgwzHtYcrCH/wtq0AEoYsrFaYhEwBIeIYiRwLvsUezN+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MU3Ykl4g; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MU3Ykl4g" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-c15ba3a2b4bso211516566b.1 for ; Mon, 10 Aug 2026 06:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786369618; x=1786974418; darn=vger.kernel.org; h=user-agent:mime-version:date:content-transfer-encoding:content-type :references:in-reply-to:cc:to:from:subject:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=VkmuAyNmOKZH0mWQNQTduJMEBCH2vZax1Arre+veBLc=; b=MU3Ykl4gy1SpdHXXV/w910+ztPPb7zDY9Nc4HV+fJes77Yo2H/wTlVmLA1uLX7SZ8s Z80iuPtP08Ksgtfeyb+1PbgaEOlw3gB7mK5XZnzxxQFVqYVipCiFpc3qJc1FOmvF41E7 Uqq8DAeFikyUkXnXQcoWiSb1PswlCC3leATmvwiSfFF0SEt5CtyHctLPHLJeFMr6KjKG +jhsUz+twOs1CGpqYC6Lmtmw5Abx93/arioKY2TOByEk7nMlNGGK0MdcZiux71T1TG+9 2m6teyijcu23CGyahoVeDzN98ie3sgO+pgfDFEua1u+M2D+76g/mtRS2I2k8bRrmzhrr lAiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786369618; x=1786974418; h=user-agent:mime-version:date:content-transfer-encoding:content-type :references:in-reply-to:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VkmuAyNmOKZH0mWQNQTduJMEBCH2vZax1Arre+veBLc=; b=NiV3qo34+JnTWEy4WLMtInAq0foTD3IIc7KFf3b3XN5VOb+lBc+n+oldw3mBoca73s VLFIVgP4G4jyB8EGnPeit2fUasR72VXopjl4Doj6kAKBzIizqcda8G3JpbIk9iaLgDFw 3lrSOS6nOVHnARb6P2RDmQcI9b2STldgfoBB4eWa8nkhQw+1+9SlZzqDAZ5jwqW4r2iX NuqMm0foIzx86rueOM1ntfSgPWQCScGqG2TusSPznlts0cMQfJiOP27DvX7YNabdE9k2 OWQfRZy45AmY9feYj4I0dGmrANb4Ko7oHlUicw6/u+brcKl/1g9B+e1nkw2gidYGjC86 wOvA== X-Forwarded-Encrypted: i=1; AHgh+RrZ6BpSLZeJZGTY3NYPfuuH3Cr7eon5S04IqVZS3KgCwpt2Ncr+4/c57oy/Gti0KvnQy+E/u8pBAnGwf0o=@vger.kernel.org X-Gm-Message-State: AOJu0YwLjxmOKPZ5FuCn/9YPKNO5QtPiVEeoTLrBH1XAHWR2No5RnfFT CA8fckRVdLV3Orc95NPYZEcHEvf5NWfKK5xY5CYRppz5/Ly06SJEgcns X-Gm-Gg: AR+sD11cGk3U2IL8bMYMr9V1Lz4ABQ4WxaRIEwKSrgZZsnvCkcRjIC3i48W5L2JuAad rhVK2Afb5MKAlmHkIpH7TtLz2Cgpt8JktEhLHy0GL7hrSlz7fabj+ZEwVZX5ruw70K/kNRetsRZ RfdB3Udp/fCfhPIuM7BHxCaOokjrrQlz+YMjzUrN73PsxIzmccARtEIrntnPijVNncQZ8wO4Xk0 bjKSq77o7guZiq8YkplA6L/G8UwFAn0sbeW7MrLN7gLRzHwrRyg+YBewf83PWmlj8uYnqMwK0Bf hVQwtK89WPCOsmU5dVLnjcwTG/hFyqeRZdxgSjMKl2nERvjBCs0LYIrgdK3J8r5Kce7+mNKG765 bMpP0O36Nd5tLuV9xhN63b+Mqg4yUel/34s6bEJdtqB+XnnzkDvO2mUDOeoI0j/IqDlpqZVNg6A 2YwQTGa9W83uUQkCKKPsFoDrJDCVaQ7C+92M0B51LbPE1f6WyuunVKKJkSWrDnHxqjd2DMn5Iya 9kaoLpIIhFme0D5IWumIJ5PrB2OimSe42QgAYBZUpBW X-Received: by 2002:a17:906:4795:b0:c15:d0b6:495c with SMTP id a640c23a62f3a-c2039e6acefmr2013592466b.29.1786369617351; Mon, 10 Aug 2026 06:46:57 -0700 (PDT) Received: from [10.198.255.130] (polaris.rmrf.org. [70.34.242.93]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2080a29a28sm387425366b.7.2026.08.10.06.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 06:46:57 -0700 (PDT) Message-ID: <1ae066f5cc91a5e6e043177774cf6ee699a7b2f5.camel@gmail.com> Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a p/n: AD3Q9ET#UUG From: Denis Batishchev To: Takashi Iwai Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <877blyccxq.wl-tiwai@suse.de> References: <20260810125209.2014042-1-ii343hbka@gmail.com> <877blyccxq.wl-tiwai@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Mon, 10 Aug 2026 15:41:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Evolution 3.56.2-9 Sorry. I'll double check what I'm doing wrong. At first I used spaces that's true. On Mon, 2026-08-10 at 15:39 +0200, Takashi Iwai wrote: > On Mon, 10 Aug 2026 14:52:09 +0200, > Denis Batishchev wrote: > >=20 > > The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec. > > Without a quirk no fixup is selected and the mic-mute LED stays off. > > It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the > > already-supported 14" variant (SSID 103c:8dfb), so add it. > >=20 > > Signed-off-by: Denis Batishchev > > Cc: > > --- > > v2: fix indentation (per Takashi Iwai ) > > --- > > sound/hda/codecs/realtek/alc269.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realt= ek/alc269.c > > index 6b36c730c..ef8beb928 100644 > > --- a/sound/hda/codecs/realtek/alc269.c > > +++ b/sound/hda/codecs/realtek/alc269.c > > @@ -7542,6 +7542,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = =3D { > > SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP= _GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_H= P_MUTE_LED_MICMUTE_VREF), > > + SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14 (AD3Q9ET#= UUG)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), >=20 > Hmm, it's still with spaces instead of tabs? >=20 >=20 > Takashi