Re: [PATCH] arm64: dts: s32g: add the pinctrl node

[Krzysztof Kozlowski <krzk@kernel.org>]

On 23/07/2024 15:56, Andrei Stefanescu wrote:
> Hi Krzysztof,
> 
> Thank you for the prompt review!
> 
> On 23/07/2024 16:38, Krzysztof Kozlowski wrote:
>> On 23/07/2024 14:37, Andrei Stefanescu wrote:
>>> +			status = "okay";
>>
>> Where did you disable it?
> 
> It isn't disabled anywhere.

Then what is the point of enabling if it is not disabled?

> I thought we should always have it enabled since most of the
> other drivers will rely on it. Should I add it here disabled and enable it in the
> board specific .dts files (in this case: s32g399a-rdb3.dts, s32g274a-rdb2.dts and
> s32g274a-evb.dts)?

No. I think coding style covers it, please read it.

> 
>>
>>> +
>>> +			jtag_pins: jtag_pins {
>>
>> Underscores are not allowed. Please follow DTS coding style. The
>> mainline one, not NXP coding style. Several other places here have also
>> issues, so be sure you read if carefully.
> 
> Thank you! I will send a V2 with  "jtag_pins: jtag-pins {" and
> all the other subnodes renamed to "jtag-grp*".

Well, fix also other coding style violations...



Best regards,
Krzysztof