From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 699DB36BCE6 for ; Fri, 27 Feb 2026 18:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772218057; cv=none; b=CLFQQOgPTc6qsn9sn3Ux/aSyE/pW+FvxSKFYEt6uCw0uag83Q/xhYUW03pHvW14ZAr0vgi5tGnjxBQseWLYMKvIumhXKFLxNT7DSBn9kS8puVCNBqJetn+pROUbQYYUlqJ7bTV5Du7vUzxvg0YtlFnnK4vBk5ynp9hk9IRIhjO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772218057; c=relaxed/simple; bh=QDmmkCh4XcSNhkdZkdVrxLFrczXRsrS/UJX0ZG7rM+0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PFiBvSiC+KfMV+w8xPYwGBn+VLIdKfz4Ay6lMns7LbifLtNEuPqK/aN0xF5ZGBAh/6P1qulys0jqUiaFbVPUrcIOcAiF/MJ001HPg5Wb3wATOrlsJQUfoWkUhcsary4CzsefBJ+1uRz39yjHbrFs6bFFug2lGW45GDzJf9uZo1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LyVZilXT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LyVZilXT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F26AC116C6; Fri, 27 Feb 2026 18:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772218057; bh=QDmmkCh4XcSNhkdZkdVrxLFrczXRsrS/UJX0ZG7rM+0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LyVZilXTEXrpWzpV0i/W25N80ipyCZtamE7Dt2WVQBxTJAqKDgSh4F7a+K+oQquNf bbl94G/ANIpkRRlvwTn5lQXAQXJSz/SK1YcwLROPvLpY51AkJIP4Me2LB6p/IRmagp AI5ycBvG2s8nMHb+wU2/hfK10lU4aE9fJFkf6O0fGnAuz+fe5i81A0CXhJzDIvZjcU viw3LKbSvSaPM/LBTITKpEmj1zL6OAl5ydrOrC964xHmsc4AMjriAb1RyFWQTn9LE4 32P006AHLVDPVNoyACzez0H85vQniu+0y8x68d4qwTAG9uDBqN+f1Qq0id9DhRTDT1 JhmdTzAAXc6+g== Message-ID: <1af07b22-65c8-46cd-b055-fa6f61b33b16@kernel.org> Date: Fri, 27 Feb 2026 12:47:35 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 9/9] accel/amdxdna: Fill invalid payload for failed command To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org, maciej.falkowski@linux.intel.com Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com References: <20260227004841.3080241-1-lizhi.hou@amd.com> Content-Language: en-US From: Mario Limonciello In-Reply-To: <20260227004841.3080241-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The title is 9/9, but I didn't get copied on 0 through 8. Was that just a mistake when you made the patch you sent out one patch instead of 9? On 2/26/26 6:48 PM, Lizhi Hou wrote: > Newer userspace applications may read the payload of a failed command > to obtain detailed error information. However, the driver and old firmware > versions may not support returning advanced error information. > In this case, initialize the command payload with an invalid value so > userspace can detect that no detailed error information is available. > > Fixes: aac243092b70 ("accel/amdxdna: Add command execution") > Signed-off-by: Lizhi Hou Would it also make sense to also detect the firmware version and indicate in the logs, IOCTL or a sysfs the feature is available for user space to detect? Nonetheless, this approach is scalable. Reviewed-by: Mario Limonciello (AMD) > --- > drivers/accel/amdxdna/aie2_ctx.c | 23 ++++++++--------------- > drivers/accel/amdxdna/amdxdna_ctx.c | 27 +++++++++++++++++++++++++++ > drivers/accel/amdxdna/amdxdna_ctx.h | 3 +++ > 3 files changed, 38 insertions(+), 15 deletions(-) > > diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c > index 622ddbf7fb6f..eb4c9d919885 100644 > --- a/drivers/accel/amdxdna/aie2_ctx.c > +++ b/drivers/accel/amdxdna/aie2_ctx.c > @@ -186,13 +186,13 @@ aie2_sched_resp_handler(void *handle, void __iomem *data, size_t size) > cmd_abo = job->cmd_bo; > > if (unlikely(job->job_timeout)) { > - amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_TIMEOUT); > + amdxdna_cmd_set_error(cmd_abo, job, 0, ERT_CMD_STATE_TIMEOUT); > ret = -EINVAL; > goto out; > } > > if (unlikely(!data) || unlikely(size != sizeof(u32))) { > - amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ABORT); > + amdxdna_cmd_set_error(cmd_abo, job, 0, ERT_CMD_STATE_ABORT); > ret = -EINVAL; > goto out; > } > @@ -202,7 +202,7 @@ aie2_sched_resp_handler(void *handle, void __iomem *data, size_t size) > if (status == AIE2_STATUS_SUCCESS) > amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_COMPLETED); > else > - amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR); > + amdxdna_cmd_set_error(cmd_abo, job, 0, ERT_CMD_STATE_ERROR); > > out: > aie2_sched_notify(job); > @@ -244,13 +244,13 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size) > cmd_abo = job->cmd_bo; > > if (unlikely(job->job_timeout)) { > - amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_TIMEOUT); > + amdxdna_cmd_set_error(cmd_abo, job, 0, ERT_CMD_STATE_TIMEOUT); > ret = -EINVAL; > goto out; > } > > if (unlikely(!data) || unlikely(size != sizeof(u32) * 3)) { > - amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ABORT); > + amdxdna_cmd_set_error(cmd_abo, job, 0, ERT_CMD_STATE_ABORT); > ret = -EINVAL; > goto out; > } > @@ -270,19 +270,12 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size) > fail_cmd_idx, fail_cmd_status); > > if (fail_cmd_status == AIE2_STATUS_SUCCESS) { > - amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ABORT); > + amdxdna_cmd_set_error(cmd_abo, job, fail_cmd_idx, ERT_CMD_STATE_ABORT); > ret = -EINVAL; > - goto out; > + } else { > + amdxdna_cmd_set_error(cmd_abo, job, fail_cmd_idx, ERT_CMD_STATE_ERROR); > } > - amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR); > > - if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) { > - struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, NULL); > - > - cc->error_index = fail_cmd_idx; > - if (cc->error_index >= cc->command_count) > - cc->error_index = 0; > - } > out: > aie2_sched_notify(job); > return ret; > diff --git a/drivers/accel/amdxdna/amdxdna_ctx.c b/drivers/accel/amdxdna/amdxdna_ctx.c > index db3aa26fb55f..405d2c62789d 100644 > --- a/drivers/accel/amdxdna/amdxdna_ctx.c > +++ b/drivers/accel/amdxdna/amdxdna_ctx.c > @@ -132,6 +132,33 @@ u32 amdxdna_cmd_get_cu_idx(struct amdxdna_gem_obj *abo) > return INVALID_CU_IDX; > } > > +int amdxdna_cmd_set_error(struct amdxdna_gem_obj *abo, > + struct amdxdna_sched_job *job, u32 cmd_idx, > + enum ert_cmd_state error_state) > +{ > + struct amdxdna_client *client = job->hwctx->client; > + struct amdxdna_cmd *cmd = abo->mem.kva; > + struct amdxdna_cmd_chain *cc = NULL; > + > + cmd->header &= ~AMDXDNA_CMD_STATE; > + cmd->header |= FIELD_PREP(AMDXDNA_CMD_STATE, error_state); > + > + if (amdxdna_cmd_get_op(abo) == ERT_CMD_CHAIN) { > + cc = amdxdna_cmd_get_payload(abo, NULL); > + cc->error_index = (cmd_idx < cc->command_count) ? cmd_idx : 0; > + abo = amdxdna_gem_get_obj(client, cc->data[0], AMDXDNA_BO_CMD); > + if (!abo) > + return -EINVAL; > + cmd = abo->mem.kva; > + } > + > + memset(cmd->data, 0xff, abo->mem.size - sizeof(*cmd)); > + if (cc) > + amdxdna_gem_put_obj(abo); > + > + return 0; > +} > + > /* > * This should be called in close() and remove(). DO NOT call in other syscalls. > * This guarantee that when hwctx and resources will be released, if user > diff --git a/drivers/accel/amdxdna/amdxdna_ctx.h b/drivers/accel/amdxdna/amdxdna_ctx.h > index 16c85f08f03c..fbdf9d000871 100644 > --- a/drivers/accel/amdxdna/amdxdna_ctx.h > +++ b/drivers/accel/amdxdna/amdxdna_ctx.h > @@ -167,6 +167,9 @@ amdxdna_cmd_get_state(struct amdxdna_gem_obj *abo) > > void *amdxdna_cmd_get_payload(struct amdxdna_gem_obj *abo, u32 *size); > u32 amdxdna_cmd_get_cu_idx(struct amdxdna_gem_obj *abo); > +int amdxdna_cmd_set_error(struct amdxdna_gem_obj *abo, > + struct amdxdna_sched_job *job, u32 cmd_idx, > + enum ert_cmd_state error_state); > > void amdxdna_sched_job_cleanup(struct amdxdna_sched_job *job); > void amdxdna_hwctx_remove_all(struct amdxdna_client *client);