From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99090266A7 for ; Wed, 17 Dec 2025 01:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765935761; cv=none; b=TE9RtOvjJWsDM2WjrCLqJXWM0kjOAeoJOh45QhYNrTkJ9IQ8mye6Hk4wDsZaSpAlMhZzk3uUUHNlWNNtZDAsjIMiDUrzFwfbsen98kziXpjQLk5Za1LdduyuaC6AsfBbUxbVEWLvhK0cYJowyVsaMU2QNr9K2qe8Nvy3Xr0fyI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765935761; c=relaxed/simple; bh=gvr3YyIrJwCgWl2y81TVAseKZmB52eSmwAJYK6Ff058=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hMd6cVDSRDfxcx64g0gdawHAcONfQaQcquUKmX47omwEOmpD9/MdTJB0bT/IuRRp+KrVCEpdQFltZudlAlLf++ccaCF+GaJKmHlWR8EEcp+j4m5kctJDbb0ukH3hxpVQXj88AMej/s+GIas00TW+wBo2ilOrhV621Ekw7DRTLx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aNupqI4p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aNupqI4p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96F76C4CEF1; Wed, 17 Dec 2025 01:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765935761; bh=gvr3YyIrJwCgWl2y81TVAseKZmB52eSmwAJYK6Ff058=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aNupqI4pwW/udVhbipYgtsUThoIMv/yfuz5sndC/+RJOlH1ZmwwCylfVk0eJOQy2V cZUp0Fe+mSTLZG+jTRxH/NTtY+ZohIN17L4RYxJOj+3BPcAa1juA12FxvjZmFS2HPS 8OIOkVbJckIR6EdSRrnW6jAwI7jbDEP3l7eRrUtYjbHRWaffRu/wJXZlcFVgae6Lot Z7v86wdJZKAkWw+0e1axD3PoTJ6JAs3K+oPl4th8eVFlF+rs2/qYL3IqBvFY5j3u5S diyN+mwePkixWhAvqiobELhBxiB4aZZ/N6va0pzqgsWvbZHJoHRTGgQf9OKxI263tz /p52RGfWgBTCw== Message-ID: <1afe4a52-2c61-4441-8e6c-5cee343d7419@kernel.org> Date: Wed, 17 Dec 2025 10:42:38 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] nvme/host: fixup some typos To: Wilfred Mallawa , James Smart , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Srinivas Kandagatla Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Wilfred Mallawa References: <20251216032931.1305349-2-wilfred.opensource@gmail.com> <20251216032931.1305349-4-wilfred.opensource@gmail.com> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20251216032931.1305349-4-wilfred.opensource@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/16/25 12:29, Wilfred Mallawa wrote: > From: Wilfred Mallawa > > Signed-off-by: Wilfred Mallawa Looks good, but write something as the commit message. One nit below. Reviewed-by: Damien Le Moal > @@ -271,7 +271,7 @@ static bool nvme_validate_passthru_nsid(struct nvme_ctrl *ctrl, > { > if (ns && nsid != ns->head->ns_id) { > dev_err(ctrl->device, > - "%s: nsid (%u) in cmd does not match nsid (%u)" > + "%s: nsid (%u) in cmd does not match nsid (%u) " > "of namespace\n", I know that Christoph does not like long lines, but it may be better to unwrap this message to make it easier to grep the code. -- Damien Le Moal Western Digital Research