From: Russ Weight <russell.h.weight@intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-fpga@vger.kernel.org, "Xu Yilun" <yilun.xu@intel.com>,
"Wu Hao" <hao.wu@intel.com>, "Tom Rix" <trix@redhat.com>,
"Moritz Fischer" <mdf@kernel.org>, "Lee Jones" <lee@kernel.org>,
"Matthew Gerlach" <matthew.gerlach@linux.intel.com>,
"Tianfei zhang" <tianfei.zhang@intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Marco Pagani" <marpagan@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 01/11] mfd: intel-m10-bmc: Add missing includes to header
Date: Tue, 17 Jan 2023 08:43:03 -0800 [thread overview]
Message-ID: <1afecb9c-b17c-d2a5-d887-b7dced939586@intel.com> (raw)
In-Reply-To: <20230116100845.6153-2-ilpo.jarvinen@linux.intel.com>
On 1/16/23 02:08, Ilpo Järvinen wrote:
> linux/mfd/intel-m10-bmc.h is using:
> - pr_err(), thus include also linux/dev_printk.h
> - FIELD_GET(), this include also linux/bitfield.h
> - GENMASK(), thus include also linux/bits.h
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> include/linux/mfd/intel-m10-bmc.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h
> index f0044b14136e..0d4db5d9d5af 100644
> --- a/include/linux/mfd/intel-m10-bmc.h
> +++ b/include/linux/mfd/intel-m10-bmc.h
> @@ -7,6 +7,9 @@
> #ifndef __MFD_INTEL_M10_BMC_H
> #define __MFD_INTEL_M10_BMC_H
>
> +#include <linux/bitfield.h>
> +#include <linux/bits.h>
> +#include <linux/dev_printk.h>
> #include <linux/regmap.h>
>
> #define M10BMC_LEGACY_BUILD_VER 0x300468
next prev parent reply other threads:[~2023-01-17 16:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 10:08 [PATCH v6 00/11] intel-m10-bmc: Split BMC to core and SPI parts & add PMCI+N6000 support Ilpo Järvinen
2023-01-16 10:08 ` [PATCH v6 01/11] mfd: intel-m10-bmc: Add missing includes to header Ilpo Järvinen
2023-01-17 16:43 ` Russ Weight [this message]
2023-01-20 3:03 ` Xu Yilun
2023-01-27 10:27 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 02/11] mfd: intel-m10-bmc: Create m10bmc_platform_info for type specific info Ilpo Järvinen
2023-01-27 10:28 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 03/11] mfd: intel-m10-bmc: Rename the local variables Ilpo Järvinen
2023-01-27 10:29 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 04/11] mfd: intel-m10-bmc: Split into core and spi specific parts Ilpo Järvinen
2023-01-27 10:35 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 05/11] mfd: intel-m10-bmc: Support multiple CSR register layouts Ilpo Järvinen
2023-01-27 10:36 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 06/11] fpga: intel-m10-bmc: Rework flash read/write Ilpo Järvinen
2023-01-27 10:37 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 07/11] mfd: intel-m10-bmc: Prefix register defines with M10BMC_N3000 Ilpo Järvinen
2023-01-27 10:38 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 08/11] fpga: m10bmc-sec: Create helpers for rsu status/progress checks Ilpo Järvinen
2023-01-27 10:39 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 09/11] fpga: m10bmc-sec: Make rsu status type specific Ilpo Järvinen
2023-01-20 3:55 ` Xu Yilun
2023-01-27 10:44 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 10/11] mfd: intel-m10-bmc: Add PMCI driver Ilpo Järvinen
2023-01-27 10:50 ` Lee Jones
2023-01-16 10:08 ` [PATCH v6 11/11] fpga: m10bmc-sec: Add support for N6000 Ilpo Järvinen
2023-01-27 15:00 ` [PATCH v6 00/11] intel-m10-bmc: Split BMC to core and SPI parts & add PMCI+N6000 support Lee Jones
2023-01-27 15:05 ` Lee Jones
2023-01-27 17:34 ` Ilpo Järvinen
2023-01-27 17:10 ` [GIT PULL] Immutable branch between MFD, FPGA and HWMON due for the v6.3 merge window Lee Jones
2023-01-30 1:33 ` Xu Yilun
2023-01-30 8:17 ` [GIT PULL v2] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1afecb9c-b17c-d2a5-d887-b7dced939586@intel.com \
--to=russell.h.weight@intel.com \
--cc=broonie@kernel.org \
--cc=hao.wu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=tianfei.zhang@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®