From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5666AC433DB for ; Thu, 11 Feb 2021 18:31:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 282F564DCF for ; Thu, 11 Feb 2021 18:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231731AbhBKSSq (ORCPT ); Thu, 11 Feb 2021 13:18:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230021AbhBKR4Q (ORCPT ); Thu, 11 Feb 2021 12:56:16 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59D95C061356 for ; Thu, 11 Feb 2021 09:55:34 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id hs11so11444739ejc.1 for ; Thu, 11 Feb 2021 09:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0pCiUpeBCgfpgLcOixXyMaSRCIE6sLsL8S3aPB3A1Nk=; b=HeDif2XiXW0gIR/nSH+Ff81eWsT3unuN2il6MYQENm81dIPu9ZEv6DQmXsFiyarW/E UuqRHRgndgNesCGAh8GQufF7YugahdZzCsyolVu5QT91ej07R7ArAlltahenuFa+nTqy k/DOxllhUSBqR4lDuj9WMVOSylyiqNLGaJl3WyzfEQn2Ftm3/iwKJJbq2UWq6cPcuFR7 IppSm9OAh0K+8VIl12BFYndJOqLCCxFfDtax1enQaA0+vTVkkJTS3nyCVCT7NUebJkcT wtmBhfUWrdhT3RadOSwxiRUvvzfV4A+3K9cyg2HFrOYoGeEt86IckSeDieAvdUMZOCw+ uzDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0pCiUpeBCgfpgLcOixXyMaSRCIE6sLsL8S3aPB3A1Nk=; b=Mn6gVSAb51pYT7PiI5TClvyXoLcMb+yiX5BxeAW4nQLjOOyMfADCPPmb7lCxU507S6 jqx9FpE1YiJd9OVrivlaDbc8TNFExlh8Mhn8BQ4mwU7C6/NbzxtXs6rmfKdG2LB7NGyT nYLH+ZpPoskm13TGcqcPa3NSyvA0hpi0h1CGLJpyh/3f3vJNowsfYLODtqD09bKDeCiz Y5MMc6ki2hoq0/czj/pNQTuRVQH9Y/Vku/Pgwim0sgJ0XDgklqZhYqLjSWIH8A0V4jFE 6uPUbmZKdzV38HjEJd+ipwxcW6gNoG+A11LK11va7reenyZ7nbB9SOG4eVqlflULchmq vM3w== X-Gm-Message-State: AOAM530QpkvhTKvkrsiC4iwGydeQ2zulzrmy3GiKxJ2WknoJcut2RV+Q M/iDs//ZjuqU/NoZsIaefduoG5yhh+9Fcg== X-Google-Smtp-Source: ABdhPJwQdtfNm5nZvjceAOzmmGCdMaSZl/CqH6DTGxgPqq7Z4GkOwRqQmeBrzORpe/zl38s7IazJkA== X-Received: by 2002:a17:906:184e:: with SMTP id w14mr9887272eje.56.1613066132520; Thu, 11 Feb 2021 09:55:32 -0800 (PST) Received: from [192.168.0.105] (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id g16sm4884187ejo.107.2021.02.11.09.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Feb 2021 09:55:31 -0800 (PST) Subject: Re: [PATCH 4/4] microblaze: Remove support for gcc < 4 To: Geert Uytterhoeven , Russell King , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210210141140.1506212-1-geert+renesas@glider.be> <20210210141140.1506212-5-geert+renesas@glider.be> From: Michal Simek Message-ID: <1b072177-e212-67ce-7d72-c3d526a480f9@monstr.eu> Date: Thu, 11 Feb 2021 18:55:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210210141140.1506212-5-geert+renesas@glider.be> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/21 3:11 PM, Geert Uytterhoeven wrote: > Since commit cafa0010cd51fb71 ("Raise the minimum required gcc version > to 4.6") , the kernel can no longer be compiled using gcc-3. > Hence drop support code for gcc-3. > > Signed-off-by: Geert Uytterhoeven > --- > arch/microblaze/kernel/module.c | 26 -------------------------- > 1 file changed, 26 deletions(-) > > diff --git a/arch/microblaze/kernel/module.c b/arch/microblaze/kernel/module.c > index 9f12e3c2bb42a319..e5db3a57b9e30d9e 100644 > --- a/arch/microblaze/kernel/module.c > +++ b/arch/microblaze/kernel/module.c > @@ -24,9 +24,6 @@ int apply_relocate_add(Elf32_Shdr *sechdrs, const char *strtab, > Elf32_Sym *sym; > unsigned long int *location; > unsigned long int value; > -#if __GNUC__ < 4 > - unsigned long int old_value; > -#endif > > pr_debug("Applying add relocation section %u to %u\n", > relsec, sechdrs[relsec].sh_info); > @@ -49,40 +46,17 @@ int apply_relocate_add(Elf32_Shdr *sechdrs, const char *strtab, > */ > > case R_MICROBLAZE_32: > -#if __GNUC__ < 4 > - old_value = *location; > - *location = value + old_value; > - > - pr_debug("R_MICROBLAZE_32 (%08lx->%08lx)\n", > - old_value, value); > -#else > *location = value; > -#endif > break; > > case R_MICROBLAZE_64: > -#if __GNUC__ < 4 > - /* Split relocs only required/used pre gcc4.1.1 */ > - old_value = ((location[0] & 0x0000FFFF) << 16) | > - (location[1] & 0x0000FFFF); > - value += old_value; > -#endif > location[0] = (location[0] & 0xFFFF0000) | > (value >> 16); > location[1] = (location[1] & 0xFFFF0000) | > (value & 0xFFFF); > -#if __GNUC__ < 4 > - pr_debug("R_MICROBLAZE_64 (%08lx->%08lx)\n", > - old_value, value); > -#endif > break; > > case R_MICROBLAZE_64_PCREL: > -#if __GNUC__ < 4 > - old_value = (location[0] & 0xFFFF) << 16 | > - (location[1] & 0xFFFF); > - value -= old_value; > -#endif > value -= (unsigned long int)(location) + 4; > location[0] = (location[0] & 0xFFFF0000) | > (value >> 16); > Applied. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs