mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Hans de Goede <hdegoede@redhat.com>, linux-kernel@vger.kernel.org
Cc: platform-driver-x86@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: silead - Add OF device ID table
Date: Wed, 22 Feb 2017 11:25:54 -0300	[thread overview]
Message-ID: <1b07bb93-29c4-c735-d07a-0da05ddc2292@osg.samsung.com> (raw)
In-Reply-To: <559a8956-0594-23e1-2437-8b595042cdaa@redhat.com>

Hello Hans,

On 02/22/2017 11:23 AM, Hans de Goede wrote:
> HI,
> 
> On 22-02-17 13:45, Javier Martinez Canillas wrote:
>> Hello Hans,
>>
>> Thanks for your feedback.
>>
>> On 02/22/2017 05:29 AM, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 21-02-17 19:12, Javier Martinez Canillas wrote:
>>>> The driver doesn't have a struct of_device_id table but supported devices
>>>> are registered via Device Trees. This is working on the assumption that a
>>>> I2C device registered via OF will always match a legacy I2C device ID and
>>>> that the MODALIAS reported will always be of the form i2c:<device>.
>>>>
>>>> But this could change in the future so the correct approach is to have an
>>>> OF device ID table if the devices are registered via OF.
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>> ---
>>>>
>>>>  drivers/input/touchscreen/silead.c | 14 ++++++++++++++
>>>>  1 file changed, 14 insertions(+)
>>>>
>>>> diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
>>>> index 404830a4a366..aae3ba1c3e02 100644
>>>> --- a/drivers/input/touchscreen/silead.c
>>>> +++ b/drivers/input/touchscreen/silead.c
>>>> @@ -580,12 +580,26 @@ static const struct acpi_device_id silead_ts_acpi_match[] = {
>>>>  MODULE_DEVICE_TABLE(acpi, silead_ts_acpi_match);
>>>>  #endif
>>>>
>>>> +#ifdef CONFIG_OF
>>>> +static const struct of_device_id silead_ts_of_match[] = {
>>>> +    { .compatible = "silead,gsl1680" },
>>>> +    { .compatible = "silead,gsl1688" },
>>>> +    { .compatible = "silead,gsl3670" },
>>>> +    { .compatible = "silead,gsl3675" },
>>>> +    { .compatible = "silead,gsl3692" },
>>>> +    { .compatible = "silead,mssl1680" },
>>>> +    { },
>>>> +};
>>>
>>> Please drop the mssl1680 compatible, that id an ACPI ugliness
>>
>> Ok, I'll drop that compatible if isn't needed for Device Tree.
>>
>>> which we don't need for devicetree.
>>>
>>
>> I'm not sure I understood your ACPI comment,
> 
> There is no silead chip named mssl1680, the mssl stands
> for microsoft silead (or so I believe) and it is used
> to identify the gsl1680 in some ACPI tables.
> 

Ah, thanks a lot for the clarification. I'll re-spin the
patch removing this entry then and adding your explanation
in the commit message.

> Regards,
> 
> Hans

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

      reply	other threads:[~2017-02-22 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 18:12 Javier Martinez Canillas
2017-02-21 18:12 ` [PATCH 2/3] Input: synaptics_i2c " Javier Martinez Canillas
2017-02-23  8:31   ` Dmitry Torokhov
2017-02-23 12:40     ` Javier Martinez Canillas
2017-02-21 18:12 ` [PATCH 3/3] Input: qt1070 " Javier Martinez Canillas
2017-02-23  8:25   ` Dmitry Torokhov
2017-02-23  8:27     ` Dmitry Torokhov
2017-02-23 12:39       ` Javier Martinez Canillas
2017-02-22  8:29 ` [PATCH 1/3] Input: silead " Hans de Goede
2017-02-22 12:45   ` Javier Martinez Canillas
2017-02-22 14:23     ` Hans de Goede
2017-02-22 14:25       ` Javier Martinez Canillas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b07bb93-29c4-c735-d07a-0da05ddc2292@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®