From: Guenter Roeck <linux@roeck-us.net>
To: "Baek Kyu, Kim" <pocj8ur4in@gmail.com>
Cc: victor.duicu@microchip.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (mcp9982) Update the interval cache only after successful writes
Date: Mon, 19 Oct 2026 13:14:04 -0700 [thread overview]
Message-ID: <1b0a818b-55ea-4f7a-92a7-721e1f78a0fe@roeck-us.net> (raw)
In-Reply-To: <20261018055750.1318723-1-pocj8ur4in@gmail.com>
On Sun, Oct 18, 2026 at 02:57:50PM +0900, Baek Kyu, Kim wrote:
> mcp9982_write() updates interval_idx before writing the conversion-rate
> register. If the write fails without changing the register, subsequent
> update_interval reads report the requested interval instead of the
> previous setting.
>
> Update interval_idx only after regmap_write() succeeds, leaving the
> previous cached interval in place on error.
>
> Fixes: e2fe950f34e5 ("hwmon: add support for MCP998X")
> Signed-off-by: Baek Kyu, Kim <pocj8ur4in@gmail.com>
> Acked-by: Duicu Victor <victor.duicu@microchip.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2026-10-19 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 5:57 Baek Kyu, Kim
2026-10-19 11:46 ` Victor.Duicu
2026-10-19 20:14 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b0a818b-55ea-4f7a-92a7-721e1f78a0fe@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pocj8ur4in@gmail.com \
--cc=victor.duicu@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®