mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: Aspecky <tarrihmoad@proton.me>
Cc: "Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D. Jones" <luke@ljones.dev>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Antheas Kapenekakis" <lkml@antheas.dev>,
	"Benjamin Tissoires" <bentiss@kernel.org>,
	"Sercan GOKMEN" <gokmensercan@gmail.com>,
	"Burak Goncu" <burakgon12@gmail.com>,
	"Denis Benato" <benato.denis96@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v4] platform/x86: asus-wmi: Ignore unusable kbd backlight WMI device on ROG Strix G814FP
Date: Sat, 14 Nov 2026 03:13:32 +0100	[thread overview]
Message-ID: <1b1257ea-e6c0-4380-a277-e20c99e047de@linux.dev> (raw)
In-Reply-To: <-sHRKK56awNgHWFUXMcBVRL0SSag0CruNAfbxPNPYJJC8qqk_N74k3wCldWqNkfw-CBwHj-6CvkYhrkCsBYqgNNUQV2oT31VbehOxMbR87E=@proton.me>

14 nov 2026 01:50:29 Aspecky <tarrihmoad@proton.me>:

> On Thursday, November 12th, 2026 at 10:21 AM, Denis Benato <denis.benato@linux.dev> wrote:
>
>>> On the ASUS ROG Strix G18 G814FP, writing a level to the keyboard
>>> backlight brightness in sysfs works, but reading it back always gives
>>> 0, and the read makes the Fn brightness keys misbehave.
>>
>> With "works" do you mean the write report success but does nothing or
>> that it is actually changing the brightness?
>
> Sorry about the confusion, the write does actually change the brightness.
> Writing 3 to /sys/class/leds/asus::kbd_backlight/brightness turns the
> LEDs to high. asus-wmi passes the level both to the WMI device and to
> hid-asus, the latter is the one that registers as a listener on the LED.
> The DEVS(0x00050021) write to the WMI device fails with -ENODEV and
> changes nothing, hid-asus is what actually sets the LEDs:
>

No, you excuse me: the question was not well expressed.

I meant if wmi actually changes something, not if the sysfs write does... From this answer I understand. Keep the description this way.


Do as if I never said anything about this :)

> sysfs write -> asus-wmi |- DEVS(0x00050021) -> firmware -> rejected
>                         |_ hid-asus -> USB HID report -> LEDs
>
>>> DSTS(0x00050021) always returns 0x50000, which is level 0
>>
>> Always returns level zero with the presence bit set.
>
> Correct, always returns level zero with the presence bit set,
> i'll say that in v5.
>
>>> As a side effect, the kbd_rgb_mode and kbd_rgb_mode_index attributes are
>>> no longer created on this board, they never worked here since the firmware
>>> rejects those writes as well.
>>
>> Isn't this a contraddiction to what is written above? That writes
>> actually succeeds?
>
> It's not a contradiction, the sysfs brightness write succeeds because
> of hid-asus, while the WMI DEVS(0x00050021) writes are rejected and
> so are the ones behind kbd_rgb_mode. The commit message doesn't make
> that clear, I'll reword it in v5 and wait a day or so in case there
> are more comments.
>

All good. I understand, proceed mentioning the presence bit and level zero and you're done.

Put a Reviewed-by: Denis Benato <denis.benato@linux.dev> in your next patch.

Thanks,
Denis

> Thanks,
> Moad


      reply	other threads:[~2026-11-14  2:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 23:36 Moad Tarrih via B4 Relay
2026-11-12 10:20 ` Denis Benato
2026-11-14  0:50   ` Aspecky
2026-11-14  2:13     ` Denis Benato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b1257ea-e6c0-4380-a277-e20c99e047de@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=benato.denis96@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=burakgon12@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=gokmensercan@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@antheas.dev \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tarrihmoad@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®