From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1E2C433EF for ; Fri, 1 Apr 2022 11:23:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345289AbiDALZO (ORCPT ); Fri, 1 Apr 2022 07:25:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344444AbiDALZH (ORCPT ); Fri, 1 Apr 2022 07:25:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6796363FE for ; Fri, 1 Apr 2022 04:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648812196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wbnHJsOa3OkhhmPzC8CDbVMXsKDpOLdvf6K+TgYYTfU=; b=PtHbBzSLf82awvwIStyQyLBsKW2xhas95xJp8LeWlC142mIxvi3ns6kXXub7RNhHyFNztA DpkT57eAJc+QspTmDEwhVPZJoAJM9wrRxQNNQdePXzR/ReIrrN3eJ6yM73RITbRmjaA+Ng 5XKyL0bxWH/uJHhEmoP1+IkD6/aFnbw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-357-BOQr7ygSOfSPzbQXWNOGOQ-1; Fri, 01 Apr 2022 07:23:15 -0400 X-MC-Unique: BOQr7ygSOfSPzbQXWNOGOQ-1 Received: by mail-ej1-f72.google.com with SMTP id my15-20020a1709065a4f00b006dfd2b16e6cso1435785ejc.1 for ; Fri, 01 Apr 2022 04:23:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=wbnHJsOa3OkhhmPzC8CDbVMXsKDpOLdvf6K+TgYYTfU=; b=6T0JWizhoqnxyJykgetDbwHLMcgTJYSM1YrL+dHH8EiAc+Ol8GBuBThjMXvApxpIby zYjIzjMs+b5X4seyDUAzm6uiB1mzFT8Vqs8iK86jl2ZswjpqMPLmTQ/jLQGLnRFrDlNe C4n3jFAyca0v47tXcOa8+J8hEPnIKfQ9mWObdclKXVuSejUwE9LHZflIvP3IaMQkztVn b2wPY0yrAMzslDyRff4YjWwF2/ELy/SzEIKHPbFWtVnWM6mzqLcmqrOrtfAevaDf1WwM Tscfiok87qBWNdQQbzqq/V/fiKXjxEK0au53uiHSkkX9BpHSolfEKBjl2emMJZ7bbCCF iZuw== X-Gm-Message-State: AOAM5339d7lJVC99RhZKFjvfzidXVW6TesrO2vA4+HEUglZCNFsYD2+3 4oej9Rmt0w0AcMkCA4/WwUFyb13CVsOJd8Yu3eB5489pP3JF40FQbSB9F5JO3sxFGVpANsKc2KU 1HZxvJSzl57sXt3WCi/BCQE5d X-Received: by 2002:a17:907:1c0a:b0:6da:7ac4:5349 with SMTP id nc10-20020a1709071c0a00b006da7ac45349mr8826151ejc.596.1648812193890; Fri, 01 Apr 2022 04:23:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcxHDVJnHI1X2NEbHLMJMiwFe+hcsJR5WLhis7f05d2t0gZ2OJ0wwpuxMsndWuIBwu+J+pHw== X-Received: by 2002:a17:907:1c0a:b0:6da:7ac4:5349 with SMTP id nc10-20020a1709071c0a00b006da7ac45349mr8826131ejc.596.1648812193567; Fri, 01 Apr 2022 04:23:13 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:8ca6:a836:a237:fed1? ([2001:b07:6468:f312:8ca6:a836:a237:fed1]) by smtp.googlemail.com with ESMTPSA id bn14-20020a170906c0ce00b006c5ef0494besm928096ejb.86.2022.04.01.04.23.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 04:23:12 -0700 (PDT) Message-ID: <1b262351-c56a-9c85-6038-d23a425b34f0@redhat.com> Date: Fri, 1 Apr 2022 13:23:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH -next] KVM: x86/mmu: Fix return value check in kvm_mmu_init_tdp_mmu() Content-Language: en-US To: Yang Yingliang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20220401071531.1841927-1-yangyingliang@huawei.com> From: Paolo Bonzini In-Reply-To: <20220401071531.1841927-1-yangyingliang@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/1/22 09:15, Yang Yingliang wrote: > If alloc_workqueue() fails, it returns NULL pointer, replaces > IS_ERR() check with NULL pointer check. > > Fixes: 1a3320dd2939 ("KVM: MMU: propagate alloc_workqueue failure") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > arch/x86/kvm/mmu/tdp_mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c > index a2f9a34a0168..7bddbb51033a 100644 > --- a/arch/x86/kvm/mmu/tdp_mmu.c > +++ b/arch/x86/kvm/mmu/tdp_mmu.c > @@ -22,8 +22,8 @@ int kvm_mmu_init_tdp_mmu(struct kvm *kvm) > return 0; > > wq = alloc_workqueue("kvm", WQ_UNBOUND|WQ_MEM_RECLAIM|WQ_CPU_INTENSIVE, 0); > - if (IS_ERR(wq)) > - return PTR_ERR(wq); > + if (!wq) > + return -ENOMEM; > > /* This should not be changed for the lifetime of the VM. */ > kvm->arch.tdp_mmu_enabled = true; Sent already by Dan Carpenter, thanks though! Paolo