From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02BC5C4332F for ; Tue, 8 Nov 2022 16:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234306AbiKHQ5P (ORCPT ); Tue, 8 Nov 2022 11:57:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234476AbiKHQ4z (ORCPT ); Tue, 8 Nov 2022 11:56:55 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AF55D59856; Tue, 8 Nov 2022 08:56:54 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D30E1FB; Tue, 8 Nov 2022 08:57:00 -0800 (PST) Received: from [10.57.5.11] (unknown [10.57.5.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F1FCB3F703; Tue, 8 Nov 2022 08:56:50 -0800 (PST) Message-ID: <1b2f25e5-cd60-a533-14be-a608f4c801bd@arm.com> Date: Tue, 8 Nov 2022 17:56:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 3/5] ACPI: PPTT: Remove acpi_find_cache_levels() To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Gavin Shan , Peter Chen , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org References: <20221108110424.166896-1-pierre.gondois@arm.com> <20221108110424.166896-4-pierre.gondois@arm.com> <20221108161315.lmm3sakza5quyzlv@bogus> Content-Language: en-US From: Pierre Gondois In-Reply-To: <20221108161315.lmm3sakza5quyzlv@bogus> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/22 17:13, Sudeep Holla wrote: > On Tue, Nov 08, 2022 at 12:04:19PM +0100, Pierre Gondois wrote: >> acpi_find_cache_levels() is used at a single place and is short >> enough to be merged into the calling function. The removal allows >> an easier renaming of the calling function in the next patch. >> >> Also reorder the parameters in the 'reversed Christmas tree' order. > > Not sure if the above is worth mentioning explicitly. Even if you do, > 'parameters' sounds very confusing to at-least me. I was searching for > the changes is some function parameters to understand what it was and > finally realised you meant the stack variable declaration order here. > Right ? Yes right, I will use another word. > > > Other than that, it looks good. > > Reviewed-by: Sudeep Holla > Regards, Pierre