From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Sushmit Singh Rathore <sushmit718@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Stephen Boyd <sboyd@kernel.org>
Cc: Abel Vesa <abel.vesa@oss.qualcomm.com>,
Abel Vesa <abelvesa@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Vinod Koul <vkoul@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] clk: qcom: gcc-sm8450: Parent the eUSB3 clkref to bi_tcxo
Date: Thu, 22 Oct 2026 09:57:12 +0200 [thread overview]
Message-ID: <1b31946a-9170-410c-b882-34e8b2b8c812@oss.qualcomm.com> (raw)
In-Reply-To: <20261020142157.1749-2-sushmit718@gmail.com>
On 10/20/26 4:21 PM, Sushmit Singh Rathore wrote:
> gcc_eusb3_0_clkref_en gates the XO reference to the eUSB2 PHY, but it
> has no parent, so its rate reads as 0. On SM8475 the SNPS eUSB2 PHY
> takes this clock as its reference and rejects a 0 Hz rate as
> unsupported, so USB doesn't probe.
>
> Parent it to bi_tcxo, as tcsrcc-sm8550 does for its clkref branches.
>
> Fixes: db0c944ee92b ("clk: qcom: Add clock driver for SM8450")
> Assisted-by: LLM
> Signed-off-by: Sushmit Singh Rathore <sushmit718@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-10-22 7:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 14:21 [PATCH v2 0/3] clk: qcom: sm8450: Fix eUSB clkref and camera clock collapse Sushmit Singh Rathore
2026-10-20 14:21 ` [PATCH v2 1/3] clk: qcom: gcc-sm8450: Parent the eUSB3 clkref to bi_tcxo Sushmit Singh Rathore
2026-10-21 8:39 ` Abel Vesa
2026-10-22 7:57 ` Konrad Dybcio [this message]
2026-10-20 14:21 ` [PATCH v2 2/3] clk: qcom: camcc-sm8450: Retain flops across camera GDSC collapse Sushmit Singh Rathore
2026-10-21 8:40 ` Abel Vesa
2026-10-22 7:57 ` Konrad Dybcio
2026-10-20 14:21 ` [PATCH v2 3/3] clk: qcom: camcc-sm8450: Park the camera RCGs when they are disabled Sushmit Singh Rathore
2026-10-21 8:40 ` Abel Vesa
2026-10-22 7:59 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b31946a-9170-410c-b882-34e8b2b8c812@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=sushmit718@gmail.com \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®