From: Joe Perches <joe@perches.com>
To: Jim Cromie <jim.cromie@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] checkpatch: cosmetic-style tweak
Date: Thu, 16 Oct 2025 08:54:37 -0700 [thread overview]
Message-ID: <1b3a9a196ddf4127e5148e33d3df7f70ae77a080.camel@perches.com> (raw)
In-Reply-To: <20251015175137.2178263-3-jim.cromie@gmail.com>
On Wed, 2025-10-15 at 11:51 -0600, Jim Cromie wrote:
> no functional change, slightly narrower on-screen, maybe clearer ?
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4019,11 +4019,13 @@ sub process {
> if ($newindent ne $goodtabindent &&
> $newindent ne $goodspaceindent) {
>
> - if (CHK("PARENTHESIS_ALIGNMENT",
> - "Alignment should match open parenthesis\n" . $hereprev) &&
> - $fix && $line =~ /^\+/) {
> + CHK("PARENTHESIS_ALIGNMENT",
> + "Alignment should match open parenthesis\n" . $hereprev)
> + and do {
> + if ($fix && $line =~ /^\+/) {
> $fixed[$fixlinenr] =~
> s/^\+[ \t]*/\+$goodtabindent/;
> + }
nack.
"and do" is not used anywhere by checkpatch
and I don't want to introduce it.
prev parent reply other threads:[~2025-10-16 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 17:51 [RFC PATCH 0/2] practical auto-QA de-noiser or -E_TOO_UGLY ? Jim Cromie
2025-10-15 17:51 ` [RFC PATCH 1/2] checkpatch: add __no_side_effects() hint/assertion macro Jim Cromie
2025-10-15 17:51 ` [RFC PATCH 2/2] checkpatch: cosmetic-style tweak Jim Cromie
2025-10-16 15:54 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b3a9a196ddf4127e5148e33d3df7f70ae77a080.camel@perches.com \
--to=joe@perches.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®