From: "Liang He" <windhl@126.com>
To: "Marc Zyngier" <maz@kernel.org>, "Miaoqian Lin" <linmq006@gmail.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()
Date: Wed, 22 Jun 2022 16:34:25 +0800 (CST) [thread overview]
Message-ID: <1b3e9050.5eb9.1818a8c64d3.Coremail.windhl@126.com> (raw)
In-Reply-To: <87letp2j9e.wl-maz@kernel.org>
At 2022-06-22 16:29:49, "Marc Zyngier" <maz@kernel.org> wrote:
>On Wed, 22 Jun 2022 09:15:56 +0100,
>"Liang He" <windhl@126.com> wrote:
>>
>>
>>
>> At 2022-06-22 16:03:26, "Marc Zyngier" <maz@kernel.org> wrote:
>> >+ Miaoqian Lin
>> >
>> >On Wed, 22 Jun 2022 07:21:38 +0100,
>> >Liang He <windhl@126.com> wrote:
>> >>
>> >> We need to add missing of_node_get() for of_find_matching_node() to
>> >> keep refcount balance.
>> >>
>> >> Note: of_find_matching_node() will decrease the refcount of its first
>> >> arg.
>> >>
>> >> Signed-off-by: Liang He <windhl@126.com>
>> >
>> >[...]
>> >
>> >Please send these refcount fixes as a series for all the irqchip
>> >drivers, not one every other day.
>> >
>>
>> Sorry, I will group similar bugs in future.
>>
>>
>> >And please synchronise with Miaoqian Lin, as you are obviously both
>> >chasing the same bugs.
>> >
>> >Thanks,
>> >
>> > M.
>>
>> Yes, before I send any new bug, I will confirm that this bug has not
>> been reported in lore.kernel.org.
>
>This is not what I meant. I am asking you to actively coordinate with
>Miaoqian, working with them as a team instead of you both sending
>competing series. I would like to see one series with patches from you
>both.
OK, I get it. This depends on Miaoqian.
@linm006@gmail.com
>
>> By the way, this is a bug missing |GET|, not |PUT|, which is
>> different with Miaoqian's and my patches before.
>
>Well, yet another reason for you both to work together, as you are
>complementing each other.
>
>Thanks,
>
> M.
>
>--
>Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-06-22 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:21 Liang He
2022-06-22 8:03 ` Marc Zyngier
2022-06-22 8:15 ` Liang He
2022-06-22 8:29 ` Marc Zyngier
2022-06-22 8:34 ` Liang He [this message]
2022-06-22 9:39 ` Miaoqian Lin
2022-06-22 9:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b3e9050.5eb9.1818a8c64d3.Coremail.windhl@126.com \
--to=windhl@126.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®