From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12617301002 for ; Mon, 22 Dec 2025 09:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766396601; cv=none; b=TcKeFwGcfVjEP06qGtqViptyIeOLd1MhD9zL+/voFTmdOoLYhlblo2tRxO0+sxmaqTNvbIXXIFHAdrXHNBm/u3LPZWoon8Mq7dZTdu27BABREojk19PPFK85Vfm/qA2bD0uHnTDcaJ9Ym0zjtHVOXlxGCYzHsuzrNS2jePzmsTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766396601; c=relaxed/simple; bh=NMPjZC1pzFOgyyiJEdVZB0AiQfYXNSt1cX6MqSMGtY8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F6YB/KcTdMzhFM4yx7pJcrh6q5ZPFmxcl47vtXUCZ+370UUlHToPfADF9t/0qImLk6zycb8K10vk+5RcLF+NmtowPy3cRU+9tOmgAbwvVYh4qYeMyiGPHCkee/KZAo8dHrcSbUcZyqGv2D6LoFwdqKW0IQI1tEMchx/oZ3ggsWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I35pNHTa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jLpr3V9A; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I35pNHTa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jLpr3V9A" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BM5gOoL2189859 for ; Mon, 22 Dec 2025 09:43:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SRN6yIHvb50RD5cHSXOJLx9V5J7+ESE2+V0TzNobP3c=; b=I35pNHTaCZ6XR6ek dfjSeGeIc2StDqkVojbLeB3W4YxYCFh7fa2iHjy+GAN5Fare3ZKH5LaF/VJc3GN6 3XjrJGoBGNjd/Iu1CmCbiLzKm7cB6FLnxjMXs3JgjkYp7e2WqJS7b7Ib7mxOm1WN 4yrZUYjOzgyXrV3ABtdh1cs45YEMyati9JpR7f97t4d7OD3QxW311LrD3KnkIUjb QOOSQKqq5RTtVoM1U9d0/xgrDzOdAWDaUch2+LIgWP29wTLn6H+utJExjEkq6zIY wovzZNH8WwBOade04GqHZ+i+ki9HldPG5tuz2aRDYXluii8QgtleC3x0LNkoRJRh cb1VHg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b702t8qhy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 09:43:19 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee05927208so16111841cf.1 for ; Mon, 22 Dec 2025 01:43:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766396598; x=1767001398; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SRN6yIHvb50RD5cHSXOJLx9V5J7+ESE2+V0TzNobP3c=; b=jLpr3V9AifaphCa3LfgLxIo5HbjoHpHIFopRIRQC+O4qDxhZ9twNbYxlJKyKl3lrP0 Kq2skcJR21K05rwVmLwp26RYi9uhEt6ahvATH+h+6ys/pV//VckvBn+opq9Vx3mp68T0 8THQOBXDG7zlYVqcGRfiKtB4brLfn36yKu+Sy8UKZXZULx1MBO2jGLY3jBMfNcK5+cmn zUbrmmrso8li1zPiPPZaEbf7Cj5MYr+JFJc5TRYVFydrfi1E75YiVYXn8Cx/vIsKC2qk 0bkVY6ex5sKldvDT715lLNRY/bZGOh6siR8bRKiR3YxzMPlotcbUYtx6HmurDX6MWjZc 7CBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766396598; x=1767001398; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SRN6yIHvb50RD5cHSXOJLx9V5J7+ESE2+V0TzNobP3c=; b=D9HuGdKnVqX2dnagRdK0fJzdNe3b9/Qg598MxIBsgu8AO3S+urqyDJ3Osic04HcVig 0IOzjHcWrp4nAInPR4+ZhgzlZM8mZO0SzKOFQj7zBbf2DzdoWk6d6o5oXiFGXjJvl9F0 hLXA7UJmY+XI8F1PvugAf0e5QiJjUBqpFXrgLf8lwJ9LaXenFQv8I/36H+hdMn0tb+9c rd+wbKGNzGqHIjWb2KYoBc55rEveBhXPBJHQIXIQ5yR230bZjCTIVe7GoFt72FqM8Iae /sbyvvu21WvRDsOIrmOTpoQwRCmGCtYzoMch2jLOrWZSxR+NA631CLZQB8eD02MoFPno ktag== X-Forwarded-Encrypted: i=1; AJvYcCW63aHTleItQJr2sSMBlboUO0aLJqO2rFvFeEc8eKZLAQC5ClFWuLskyl5JaLxNjmQ6JDOrCRp6wMI7gvk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxqr6mbhB6Mn62etySMYAcQWwT0lsEo0DOTjvdO8rHbRWmlBbBe 3CxVURz3U34bQyBimH3PWFX9Or3KgZnhxlkQjPW7Vy4bL+lmhnzTnmdfEoW3QExM5LNlTYh2ifB NM6dQwE9OH7gWxCE0MYJ/vFkGr2406FUy7vf6VGa8fScXwTMoZyekCWMbuHshA7E68hA= X-Gm-Gg: AY/fxX5vvkNLJVGze0o5gc3rXQe7kqQ6r0xn7wwcpVD3yhpna03HHCEityENsEhnMNO aDrl+YcIpuBKiB0CVv9jbVLPcL2e5Gk5upQzKwV7xOCTsg7XII390t3Ffesqtm2g2vCWT2rOzji Ecf1+uoIPmIK+2x/ugWurLWDv/czfRpE13t/7I1OOAujXRF42ca5kZHSV7wn0KZ6dBhvO3ZUro4 An6fFwIOWnk86wmjqH4yuDmPrKwGRpFDvu/oRzi3X49UIkKeBIkekeaJQyFFmXKpZPHjQvZ1hfQ rYm6lu7qHaM5iw45o1Nk/WlxLvJetsEmNNNPKFR6SkPqXXU3L0lAQFvrUjfJe3iplTEdAKTOedT s86/r9nVYk5jCBjc2HKibiIiOusqmyBVh2SCNl7ZFNl9LvBjwWLI4ShYfQREsoDEOGg== X-Received: by 2002:ac8:7c49:0:b0:4ed:b409:ca27 with SMTP id d75a77b69052e-4f4abde36bemr115663981cf.10.1766396598110; Mon, 22 Dec 2025 01:43:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWEjq6Tt4UdxaYQznLhDZd0HwoWnAEDuVsJfSlwF5bhgr6WXMGypxWePXMaLpyymFWQ8ptQw== X-Received: by 2002:ac8:7c49:0:b0:4ed:b409:ca27 with SMTP id d75a77b69052e-4f4abde36bemr115663781cf.10.1766396597726; Mon, 22 Dec 2025 01:43:17 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91494c0esm9803980a12.20.2025.12.22.01.43.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 01:43:17 -0800 (PST) Message-ID: <1b40552e-b292-4207-b7eb-9f50e37fd7e4@oss.qualcomm.com> Date: Mon, 22 Dec 2025 10:43:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mtd: devices: Add Qualcomm SCM storage driver To: Junhao Xie , Bjorn Andersson , Konrad Dybcio Cc: Xilin Wu , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mtd@lists.infradead.org References: <20251218180205.930961-1-bigfoot@radxa.com> <4AB2F6CA8EF1ED90+cd685c52-a4c2-492d-9445-b081d4d857f7@radxa.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <4AB2F6CA8EF1ED90+cd685c52-a4c2-492d-9445-b081d4d857f7@radxa.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=SIhPlevH c=1 sm=1 tr=0 ts=694912b7 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=ksxQWNrZAAAA:8 a=pYEcKcru8prnKPtxzWcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=l7WU34MJF0Z5EO9KEJC3:22 X-Proofpoint-ORIG-GUID: 6efhGmYc4qxIGrKr5pKURB7qSQxOUuH_ X-Proofpoint-GUID: 6efhGmYc4qxIGrKr5pKURB7qSQxOUuH_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDA4NyBTYWx0ZWRfX997GhFMH/xHG drxLsO4Z3kG4ji/qJK+M5NUq2YklfOxwP+azQAbvJsJc2y9RNwrekaGcP2Q92/gDbvPTc5Ikyot Tifv+wbzaJ4piSwbKqS/N1cipwksS+1TbfZPsub3ciV1E9/qt0XE7CiKR0H96fVTYY+6JFcP8Wx Dzfg3kXdMrn0WiIGWfNTiW2FX2TMfSeJAPaKk6HzWnBL9jJsCiM6untMexo70sdJoYZITCVica6 40lfV8w/87+ntw5V99Z2USBke0bhHazQ57vt59iOrdqY9qk3F9lFtyR45AhmhbyRctlCXXC29nJ p+9d2jsGL49B++12qY1aX7WsOqFFMKN4/3B0QYgrZxonxwOXn5SYgun6rDEyQPHco2LRIP+BnDj nx8miUDkro679ucw8f+RHT3fPg1Q3wPe3ROv5tPYtjJgrGFKMHadveL82fBcID0orw0D+rlTD5w mHgGaYwnWPVOC6gfjXQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-21_05,2025-12-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220087 On 12/19/25 6:12 PM, Junhao Xie wrote: > On 2025/12/19 20:05, Konrad Dybcio wrote: >> On 12/18/25 7:02 PM, Junhao Xie wrote: >>> Add MTD driver for accessing storage devices managed by Qualcomm's >>> TrustZone firmware. On some platforms, BIOS/firmware storage (typically >>> SPI NOR flash) is not directly accessible from the non-secure world and >>> all operations must go through SCM (Secure Channel Manager) calls. >>> >>> Signed-off-by: Junhao Xie >>> Tested-by: Xilin Wu >>> --- [...] >>> + host->buffer_size = SZ_256K; >> Should this just be = host->info->page_size? > > The value of page_size is smaller than what we want for > buffering SCM transfers. The buffer is intended for batching > larger operations, so a larger fixed size is used here. > > struct qcom_scm_storage_info: >   total_blocks = 8192 >   block_size = 4096 >   page_size = 256 >   num_physical = 0 >   manufacturer_id = 0 >   serial_num = 1663215 >   fw_version =  >   memory_type = NOR I don't see how the big buffer is any useful TBF - you read into this buffer before outputting to *buf and copy data from *buf into the host_buffer instead of writing straight from the former. If anything, that's an unnecessary copy. Konrad