From: Andrew Lunn <andrew@lunn.ch>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
jacob.e.keller@intel.com, horms@kernel.org, sd@queasysnail.net,
chunkeey@gmail.com
Subject: Re: [PATCH 2/6] net: ibm: emac: manage emac_irq with devm
Date: Mon, 2 Sep 2024 22:39:37 +0200 [thread overview]
Message-ID: <1b4d53d9-b797-4a4b-bce5-227efedac451@lunn.ch> (raw)
In-Reply-To: <CAKxU2N8TsYHvM7a_Dhu34xHbvrWev9eL8VOa1JZcu_naW3fwjg@mail.gmail.com>
> > Is this an internal interrupt, or a GPIO? It could be it is done in
> > open because there is a danger the GPIO controller has not probed
> > yet. So here you might get an EPROBE_DEFFER, where as the much older
> > kernel this was written for might not of done, if just gave an error
> > had gave up. So dev_err_probe() might be better.
> Good call on that. In my experience, I get these EPROBE_DEFER errors
> on OpenWrt's ath79 target (QCA MIPS) but not on PowerPC when trying to
> use GPIOs. Nevertheless it seems to be good practice to use
> dev_err_probe anyway. Will fix in v2.
You might want to look at
https://elixir.bootlin.com/linux/v6.10.7/source/drivers/net/ethernet/ibm/emac/core.c#L2418
and then replace it by correctly handling EPROBE_DEFER.
As you said, an old driver, needing some cleanup.
Andrew
next prev parent reply other threads:[~2024-09-02 20:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 18:15 [PATCH net-next 0/6] net: ibm: emac: some cleanups and devm Rosen Penev
2024-09-02 18:15 ` [PATCH 1/6] net: ibm: emac: use devm for alloc_etherdev Rosen Penev
2024-09-02 18:15 ` [PATCH 2/6] net: ibm: emac: manage emac_irq with devm Rosen Penev
2024-09-02 20:06 ` Andrew Lunn
2024-09-02 20:26 ` Rosen Penev
2024-09-02 20:39 ` Andrew Lunn [this message]
2024-09-02 18:15 ` [PATCH 3/6] net: ibm: emac: use devm for of_iomap Rosen Penev
2024-09-02 18:15 ` [PATCH 4/6] net: ibm: emac: remove mii_bus with devm Rosen Penev
2024-09-02 18:15 ` [PATCH 5/6] net: ibm: emac: use devm for register_netdev Rosen Penev
2024-09-02 18:15 ` [PATCH 6/6] net: ibm: emac: use netdev's phydev directly Rosen Penev
2024-09-02 20:00 ` [PATCH net-next 0/6] net: ibm: emac: some cleanups and devm Andrew Lunn
2024-09-02 20:20 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b4d53d9-b797-4a4b-bce5-227efedac451@lunn.ch \
--to=andrew@lunn.ch \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®