From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C49C48BE6 for ; Sat, 12 Jun 2021 02:27:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E17EE610C7 for ; Sat, 12 Jun 2021 02:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230385AbhFLCZ6 (ORCPT ); Fri, 11 Jun 2021 22:25:58 -0400 Received: from mga02.intel.com ([134.134.136.20]:39336 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230236AbhFLCZ5 (ORCPT ); Fri, 11 Jun 2021 22:25:57 -0400 IronPort-SDR: PNKvEaB185BBk7GR38Jf4HSFn/j1ek6W793Umvr8Do+UZkDUKodC30BigcfynF+8LVE9lPmpsU iEiF9VFr9BeQ== X-IronPort-AV: E=McAfee;i="6200,9189,10012"; a="192750367" X-IronPort-AV: E=Sophos;i="5.83,268,1616482800"; d="scan'208";a="192750367" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 19:23:59 -0700 IronPort-SDR: 8jemTF4V0VjmsAdxVI3xwFWfjUYCw9xzJh7FOp6AoqNXBh/ztgG/X7Oj+GXtkg1td9PDZT1y0V mthyX7dqWpzA== X-IronPort-AV: E=Sophos;i="5.83,268,1616482800"; d="scan'208";a="483473995" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.238.4.20]) ([10.238.4.20]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 19:23:56 -0700 Cc: baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linuxarm@huawei.com, thunder.leizhen@huawei.com, chenxiang66@hisilicon.com Subject: Re: [PATCH v12 5/5] iommu: Remove mode argument from iommu_set_dma_strict() To: John Garry , joro@8bytes.org, will@kernel.org, dwmw2@infradead.org, robin.murphy@arm.com References: <1623414043-40745-1-git-send-email-john.garry@huawei.com> <1623414043-40745-6-git-send-email-john.garry@huawei.com> From: Lu Baolu Message-ID: <1b58516d-73d5-0c40-11de-58b998ec803e@linux.intel.com> Date: Sat, 12 Jun 2021 10:23:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1623414043-40745-6-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/11 20:20, John Garry wrote: > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index ccbd5d4c1a50..146cb71c7441 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -350,10 +350,9 @@ static int __init iommu_dma_setup(char *str) > } > early_param("iommu.strict", iommu_dma_setup); > > -void iommu_set_dma_strict(bool strict) > +void iommu_set_dma_strict(void) > { > - if (strict || !(iommu_cmd_line & IOMMU_CMD_LINE_STRICT)) > - iommu_dma_strict = strict; > + iommu_dma_strict = true; > } Will this change break the functionality of iommu.strict? Best regards, baolu