mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Devarsh Thakkar <devarsht@ti.com>
To: Brandon Brnich <b-brnich@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Cc: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<praneeth@ti.com>, <a-bhatia1@ti.com>, <j-luthra@ti.com>,
	<detheridge@ti.com>, <p-mantena@ti.com>, <vijayp@ti.com>
Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-am62p5-sk: Reserve 576 MiB of global CMA
Date: Fri, 21 Jun 2024 21:44:30 +0530	[thread overview]
Message-ID: <1b5e3175-c9b7-4fb5-b405-e46373a6a469@ti.com> (raw)
In-Reply-To: <20240614170409.zu4vaatdac4o6w2o@udba0500997>

Hi Vignesh,

On 14/06/24 22:34, Brandon Brnich wrote:
[..]

>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
>> index fb980d46e304..5ef74d9f8eea 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
>> @@ -48,6 +48,13 @@ reserved-memory {
>>  		#size-cells = <2>;
>>  		ranges;
>>  
>> +		linux,cma {
>> +			compatible = "shared-dma-pool";
>> +			reusable;
>> +			size = <0x00 0x24000000>;
>> +			linux,cma-default;
>> +		};
> 
> Since AM62p has 8gb memory, this allocation can come from upper portion.
> Doing so breaks Wave5 encoding/decoding as the driver can not yet handle
> 48 bit addressing. 48bit support is scheduled to be upstreamed, but unsure of
> when this will actually make it in.  
> 
> Could we force this into lower 32bits using same
> alloc-ranges as done in your AM62a patch[0]?
> 


I would like to take a look at this separately, is it possible for you
to drop this patch [3/3] from series due to above comments and take the
rest two from the series ?

Regards
Devarsh

  reply	other threads:[~2024-06-21 16:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13 15:08 [PATCH 0/3] Add global CMA reserve area Devarsh Thakkar
2024-06-13 15:09 ` [PATCH 1/3] arm64: dts: ti: k3-am62x-sk-common: Reserve 128MiB of global CMA Devarsh Thakkar
2024-06-13 15:09 ` [PATCH 2/3] arm64: dts: ti: k3-am62a7-sk: Reserve 576MiB " Devarsh Thakkar
2024-06-14 17:27   ` Brandon Brnich
2024-06-13 15:09 ` [PATCH 3/3] arm64: dts: ti: k3-am62p5-sk: Reserve 576 MiB " Devarsh Thakkar
2024-06-14 17:04   ` Brandon Brnich
2024-06-21 16:14     ` Devarsh Thakkar [this message]
2024-06-14 17:58 ` [PATCH 0/3] Add global CMA reserve area Randolph Sapp
2024-06-24 16:33   ` Andrew Davis
2024-06-28 15:57     ` Devarsh Thakkar
2024-06-28 16:35       ` Randolph Sapp
2024-06-30  7:09         ` Vignesh Raghavendra
2024-07-01 14:33           ` Andrew Davis
2024-07-01 18:26             ` Randolph Sapp
2024-07-05 13:18 ` (subset)[PATCH " Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b5e3175-c9b7-4fb5-b405-e46373a6a469@ti.com \
    --to=devarsht@ti.com \
    --cc=a-bhatia1@ti.com \
    --cc=b-brnich@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=detheridge@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-luthra@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=p-mantena@ti.com \
    --cc=praneeth@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=vijayp@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®