From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C973C4741F for ; Mon, 9 Nov 2020 13:37:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2B3F206B2 for ; Mon, 9 Nov 2020 13:37:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E2GUPcpn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732871AbgKINhk (ORCPT ); Mon, 9 Nov 2020 08:37:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:39729 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730733AbgKINhg (ORCPT ); Mon, 9 Nov 2020 08:37:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604929055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vo+cO/LNGoPT1bsa0vhqVm/6CFvb1OA4fjV8AjbaH64=; b=E2GUPcpn668BxMx27yl16obvrcvu+IpJam/JqdCdCvW3HHmY3MwZgWFzig831ds4e4zfGo ucRJoXEgTrfOLCIdyZctgQZwq7pYagQLNMiXQchl/KY4U/PZ/VkIru54baZL4+dxZbkVpc sjMCpy9xuD+AgHqj1YeoLVnMq5qimn4= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-dy2UOf40MR-h4g_3IX5sOg-1; Mon, 09 Nov 2020 08:37:31 -0500 X-MC-Unique: dy2UOf40MR-h4g_3IX5sOg-1 Received: by mail-ed1-f71.google.com with SMTP id l12so2711008edw.11 for ; Mon, 09 Nov 2020 05:37:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Vo+cO/LNGoPT1bsa0vhqVm/6CFvb1OA4fjV8AjbaH64=; b=f8rfEgLp1dPR3t6fkAvOeU2TtGfEh/W0w/TvYriAMt6+9RXigBn5iEHOy32hCQZ8uK TqyE+nAOLmu3o7T92y81LDSJxt5k6BzVIuXJ0cxGSWfDP7TI2gDD4MYktr60fvlZhy25 jFEknr6l3lhY+3n4FCxM1m11THtHEaSMNJXGXk8ZbafWvBUd3UaeCiLOjf0rloqlDeeg h46Ugus6EMpMdNHwT3MyNqY2uCT9r8zmQoKbpm6586EwEeb7iRkm5K8R/r/C4INE6064 5NWV55Zdi2WHrXBmImhR7boQqxH32l65yqkaoL6fYfuESOvH89Rzh0Gp/VA0QZq5cSom wmpQ== X-Gm-Message-State: AOAM530L5D9WUZ2LKFmyvMtGC3J4pP+YCNmjuT2MuAP7o4BWj7PznAMb ljQh5czSAfoz/3hx18+fyMsacmahLiWVH7+N9GwUmawXYRsr8dksxszoaZgd29T7cdEDRHizJ5F DtRMwIlkrvKoARwXeB2wQFIP6 X-Received: by 2002:a05:6402:141:: with SMTP id s1mr14869279edu.87.1604929050157; Mon, 09 Nov 2020 05:37:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxuQ6FsIO36mhFnvxPw7RhYbSoCdxR7tjK6DBJFPoceOlCj5Tl6mBAK5aRnLvzv5GT7qzlxPw== X-Received: by 2002:a05:6402:141:: with SMTP id s1mr14869256edu.87.1604929049864; Mon, 09 Nov 2020 05:37:29 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-6c10-fbf3-14c4-884c.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:6c10:fbf3:14c4:884c]) by smtp.gmail.com with ESMTPSA id a10sm8889799edn.77.2020.11.09.05.37.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2020 05:37:29 -0800 (PST) Subject: Re: [PATCH] thinkpad_acpi: add P1 gen3 second fan support To: Iakov 'Jake' Kirilenko , Henrique de Moraes Holschuh Cc: Mark Gross , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201105152556.34073-1-jake.kirilenko@gmail.com> From: Hans de Goede Message-ID: <1b5ec9ac-a587-2b6e-83da-f3b3c18efd43@redhat.com> Date: Mon, 9 Nov 2020 14:37:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201105152556.34073-1-jake.kirilenko@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/5/20 4:25 PM, Iakov 'Jake' Kirilenko wrote: > Tested on my P1 gen3, works fine with `thinkfan`. Since thinkpad_acpi fan > control is off by default, it is safe to add 2nd fan control for brave > overclockers > > Signed-off-by: Iakov 'Jake' Kirilenko Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/thinkpad_acpi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index e38106750..4d64ba291 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -8776,6 +8776,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = { > TPACPI_Q_LNV3('N', '2', 'C', TPACPI_FAN_2CTL), /* P52 / P72 */ > TPACPI_Q_LNV3('N', '2', 'E', TPACPI_FAN_2CTL), /* P1 / X1 Extreme (1st gen) */ > TPACPI_Q_LNV3('N', '2', 'O', TPACPI_FAN_2CTL), /* P1 / X1 Extreme (2nd gen) */ > + TPACPI_Q_LNV3('N', '2', 'V', TPACPI_FAN_2CTL), /* P1 / X1 Extreme (3nd gen) */ > }; > > static int __init fan_init(struct ibm_init_struct *iibm) >