From: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Flavio Suligoi <f.suligoi@asem.it>
Cc: Jiri Slaby <jirislaby@kernel.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] serial: 8250_fintek: Print Fintek chip name
Date: Tue, 15 Dec 2020 08:29:41 +0800 [thread overview]
Message-ID: <1b5f557d-165b-d2be-2c61-ef133019edf7@gmail.com> (raw)
In-Reply-To: <X9dr2IvOgPyhsalE@kroah.com>
Hi,
Greg Kroah-Hartman 於 2020/12/14 下午 09:42 寫道:
>> pdata->pid = chip;
>> +
>> + pr_info("%s%s%s Fintek %s\n",
>> + uart->port.dev ? dev_name(uart->port.dev) : "",
>> + uart->port.dev ? ": " : "",
>> + uart->port.name,
>> + chip_name);
>
> Drivers, if all goes well, should not print anything to the kernel log.
> This isn't ok.
>
> And even if it was, dev_info() would be the correct thing to do...
Maybe can transform pr_info() to dev_dbg() for debug usage ?
--
With Best Regards,
Peter Hong
next prev parent reply other threads:[~2020-12-15 0:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 13:14 Flavio Suligoi
2020-12-14 13:42 ` Greg Kroah-Hartman
2020-12-15 0:29 ` Ji-Ze Hong (Peter Hong) [this message]
2020-12-15 6:30 ` Jiri Slaby
2020-12-15 13:35 ` R: " Flavio Suligoi
2020-12-15 13:42 ` Greg Kroah-Hartman
2020-12-15 14:06 ` R: " Flavio Suligoi
2020-12-15 14:38 ` Greg Kroah-Hartman
2020-12-15 15:06 ` R: " Flavio Suligoi
2020-12-16 0:53 ` Ji-Ze Hong (Peter Hong)
2020-12-16 9:44 ` R: " Flavio Suligoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b5f557d-165b-d2be-2c61-ef133019edf7@gmail.com \
--to=hpeter@gmail.com \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome