From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E15CAC433E0 for ; Wed, 15 Jul 2020 07:12:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9AC22065E for ; Wed, 15 Jul 2020 07:12:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729108AbgGOHMK (ORCPT ); Wed, 15 Jul 2020 03:12:10 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7316 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725852AbgGOHMK (ORCPT ); Wed, 15 Jul 2020 03:12:10 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 61AE4A5AF7F51AD256AB; Wed, 15 Jul 2020 15:12:02 +0800 (CST) Received: from [127.0.0.1] (10.174.177.219) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Wed, 15 Jul 2020 15:11:57 +0800 Subject: Re: [PATCH v4 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails To: Cong Wang CC: David Miller , Jakub Kicinski , "Jiri Pirko" , Eric Dumazet , "Linux Kernel Network Developers" , LKML References: <20200715014930.323472-1-chenweilong@huawei.com> From: Weilong Chen Message-ID: <1b62058a-8f49-bb5e-685f-48da16f1fb1e@huawei.com> Date: Wed, 15 Jul 2020 15:11:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.219] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/7/15 13:45, Cong Wang wrote: > On Tue, Jul 14, 2020 at 6:27 PM Weilong Chen wrote: >> >> When vlan_newlink call register_vlan_dev fails, it might return error >> with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should >> free the memory. But currently rtnl_newlink only free the memory which >> state is NETREG_UNINITIALIZED. >> >> BUG: memory leak >> unreferenced object 0xffff8881051de000 (size 4096): >> comm "syz-executor139", pid 560, jiffies 4294745346 (age 32.445s) >> hex dump (first 32 bytes): >> 76 6c 61 6e 32 00 00 00 00 00 00 00 00 00 00 00 vlan2........... >> 00 45 28 03 81 88 ff ff 00 00 00 00 00 00 00 00 .E(............. >> backtrace: >> [<0000000047527e31>] kmalloc_node include/linux/slab.h:578 [inline] >> [<0000000047527e31>] kvmalloc_node+0x33/0xd0 mm/util.c:574 >> [<000000002b59e3bc>] kvmalloc include/linux/mm.h:753 [inline] >> [<000000002b59e3bc>] kvzalloc include/linux/mm.h:761 [inline] >> [<000000002b59e3bc>] alloc_netdev_mqs+0x83/0xd90 net/core/dev.c:9929 >> [<000000006076752a>] rtnl_create_link+0x2c0/0xa20 net/core/rtnetlink.c:3067 >> [<00000000572b3be5>] __rtnl_newlink+0xc9c/0x1330 net/core/rtnetlink.c:3329 >> [<00000000e84ea553>] rtnl_newlink+0x66/0x90 net/core/rtnetlink.c:3397 >> [<0000000052c7c0a9>] rtnetlink_rcv_msg+0x540/0x990 net/core/rtnetlink.c:5460 >> [<000000004b5cb379>] netlink_rcv_skb+0x12b/0x3a0 net/netlink/af_netlink.c:2469 >> [<00000000c71c20d3>] netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline] >> [<00000000c71c20d3>] netlink_unicast+0x4c6/0x690 net/netlink/af_netlink.c:1329 >> [<00000000cca72fa9>] netlink_sendmsg+0x735/0xcc0 net/netlink/af_netlink.c:1918 >> [<000000009221ebf7>] sock_sendmsg_nosec net/socket.c:652 [inline] >> [<000000009221ebf7>] sock_sendmsg+0x109/0x140 net/socket.c:672 >> [<000000001c30ffe4>] ____sys_sendmsg+0x5f5/0x780 net/socket.c:2352 >> [<00000000b71ca6f3>] ___sys_sendmsg+0x11d/0x1a0 net/socket.c:2406 >> [<0000000007297384>] __sys_sendmsg+0xeb/0x1b0 net/socket.c:2439 >> [<000000000eb29b11>] do_syscall_64+0x56/0xa0 arch/x86/entry/common.c:359 >> [<000000006839b4d0>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 >> >> Fixes: e51fb152318ee6 ("rtnetlink: fix a memory leak when ->newlink fails") > > This bug is apparently not introduced by my commit above. > > It should be commit cb626bf566eb4433318d35681286c494f0, > right? That commit introduced NETREG_UNREGISTERED on the path. > Yes, you'er right, I'll resubmit. Thanks. > . >