From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951AbdB0Oph convert rfc822-to-8bit (ORCPT ); Mon, 27 Feb 2017 09:45:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42900 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbdB0Opd (ORCPT ); Mon, 27 Feb 2017 09:45:33 -0500 Subject: Re: [PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed() To: Davidlohr Bueso References: <1487786634-22641-1-git-send-email-longman@redhat.com> <1487786634-22641-3-git-send-email-longman@redhat.com> <20170226183341.GD5126@linux-80c1.suse> Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org From: Waiman Long Organization: Red Hat Message-ID: <1b64e661-4f95-9dcf-058b-0cebbcfa7294@redhat.com> Date: Mon, 27 Feb 2017 09:22:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170226183341.GD5126@linux-80c1.suse> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 27 Feb 2017 14:22:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2017 01:33 PM, Davidlohr Bueso wrote: > On Wed, 22 Feb 2017, Waiman Long wrote: > >> Move the rwsem_down_read_failed() function down to below the >> optimistic spinning section as it is going to use function in that >> section in a later patch. > > So the title is a bit ambiguous, and I would argue that this > should be folded into patch 3, and just mention it in the > changelog. > > Thanks, > Davidlohr I can reword the title to clarify it a bit more. The reason why it is a separate patch is because it will make it much harder to review the third patch otherwise. What you get from the diff will be a total replacement of one function block by another function block. I would like to make the review focus on what is actually being changed. Cheers, Longman