From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Markus Elfring" <Markus.Elfring@web.de>,
linux-aspeed@lists.ozlabs.org, linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Billy Tsai" <billy_tsai@aspeedtech.com>,
"Günter Röck" <linux@roeck-us.net>,
"Joel Stanley" <joel@jms.id.au>,
"Ryan Chen" <ryan_chen@aspeedtech.com>,
"Tan Siewert" <tan.siewert@9elements.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Felix Gu <ustc.gu@gmail.com>
Subject: Re: [PATCH] hwmon: (aspeed-g6-pwm-tach) Use devm_reset_control_get_exclusive_deasserted() in aspeed_pwm_tach_probe()
Date: Mon, 16 Nov 2026 12:00:32 +0100 [thread overview]
Message-ID: <1b6620f4c2cbed3124e5521f18585132d2e8dca2.camel@pengutronix.de> (raw)
In-Reply-To: <bbbc7228-cf98-437d-b240-ad29ee7fb4ac@web.de>
On Sa, 2026-11-14 at 17:28 +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 14 Nov 2026 17:11:34 +0100
>
> Use devm_reset_control_get_exclusive_deasserted() to replace the
> explicit reset acquisition, deassertion, and cleanup action registered
> with devm_add_action_or_reset().
> Simplify reset handling and remove the custom reset assertion callback
> while preserving reset assertion during cleanup.
>
> The source code was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
It looks like the reset_control doesn't have to be stored in
aspeed_pwm_tach_data, it could be a local variable. That is a
preexisting issue though.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
prev parent reply other threads:[~2026-11-16 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 16:28 Markus Elfring
2026-11-16 11:00 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b6620f4c2cbed3124e5521f18585132d2e8dca2.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Markus.Elfring@web.de \
--cc=andrew@codeconstruct.com.au \
--cc=billy_tsai@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ryan_chen@aspeedtech.com \
--cc=tan.siewert@9elements.com \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®