From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F0AC43381 for ; Tue, 26 Mar 2019 20:53:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77D972087C for ; Tue, 26 Mar 2019 20:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732741AbfCZUxQ (ORCPT ); Tue, 26 Mar 2019 16:53:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60656 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbfCZUxP (ORCPT ); Tue, 26 Mar 2019 16:53:15 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EBF0830FE5B2; Tue, 26 Mar 2019 20:53:14 +0000 (UTC) Received: from [10.18.17.208] (dhcp-17-208.bos.redhat.com [10.18.17.208]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D88417DC5; Tue, 26 Mar 2019 20:53:13 +0000 (UTC) Subject: Re: [PATCH v2 2/8] kbuild: Support for Symbols.list creation To: Joao Moreira , Miroslav Benes Cc: live-patching@vger.kernel.org, pmladek@suse.cz, jikos@suse.cz, nstange@suse.de, jpoimboe@redhat.com, khlebnikov@yandex-team.ru, jeyu@kernel.org, matz@suse.de, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, linux-kbuild@vger.kernel.org, michal.lkml@markovi.net References: <20190301141313.15057-1-jmoreira@suse.de> <20190301141313.15057-3-jmoreira@suse.de> <20190318191926.GA23138@redhat.com> <5f615af5-ced7-2361-5b71-71fece8b43c5@suse.de> <699e78da-36ba-8217-c509-2e9b443bd380@suse.de> From: Joe Lawrence Message-ID: <1b6ee81b-5699-a1cc-9a85-02df0eeaed12@redhat.com> Date: Tue, 26 Mar 2019 16:53:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <699e78da-36ba-8217-c509-2e9b443bd380@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 26 Mar 2019 20:53:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/26/19 2:13 PM, Joao Moreira wrote: > > > On 3/26/19 1:15 PM, Joe Lawrence wrote: >> >> Hi Joao, >> >> This change seems to work okay for (again) single object modules, but >> I'm having issues with multi-object modules. >> > > Hi Joe, thanks for the sources, this made everything much easier in my > side :) > > In the patch below I change a little bit the interface used to inform > kbuild that a module is a livepatch. Instead of defining the flag > LIVEPATCH_ per .o file, we define it per module (what actually makes > much more sense). We later use $(basetarget) in the Makefile for > checking the flags. By doing so, and invoking cmd_livepatch both from > the $(single-used-m) and $(multi-used-m) we ensure that the .livepatch > file is created for each module, what later in the pipeline flags the > invocation of klp-convert. > > I tested the following patch with the sources you provided (with little > modifications, removing the .o from the LIVEPATCH_ definitions and using > the module name instead of the object names), achieving successful > compilation and conversion. I also tested against the sample > livepatches, thus I think it might be ok now. Cool thanks for taking a look -- I can confirm that the toy code I sent over builds with those modifications and so does the sample and selftest I was working on. I'll set about refactoring that klp-convert selftest to combine .o files into a more compact module. > Do you think we can go this way to solve the problem in v3? Yeah, I'll add it to the list of patches to squash for v3. Thanks, -- Joe