From: Hans Verkuil <hverkuil@xs4all.nl>
To: Mitali Borkar <mitaliborkar810@gmail.com>,
clabbe@baylibre.com, mchehab@kernel.org,
gregkh@linuxfoundation.org
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
mitali_s@me.iitr.ac.in
Subject: Re: [PATCH v3 1/2] media: zoran: add spaces around '<<'
Date: Tue, 13 Apr 2021 17:02:26 +0200 [thread overview]
Message-ID: <1b70e00e-383f-17c2-231e-e7e8a11acf90@xs4all.nl> (raw)
In-Reply-To: <8e8ac690d97478f7cbb9b91d46ef7a95e4444e5f.1618066787.git.mitaliborkar810@gmail.com>
Missing commit message.
You used to have one in v1 of this patch!
Regards,
Hans
On 10/04/2021 17:33, Mitali Borkar wrote:
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
> Changes from v2:- No changes.
> Changes from v1:- NO changes.
>
> drivers/staging/media/zoran/zr36057.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zr36057.h b/drivers/staging/media/zoran/zr36057.h
> index 71b651add35a..a2a75fd9f535 100644
> --- a/drivers/staging/media/zoran/zr36057.h
> +++ b/drivers/staging/media/zoran/zr36057.h
> @@ -30,13 +30,13 @@
> #define ZR36057_VFESPFR_HOR_DCM 14
> #define ZR36057_VFESPFR_VER_DCM 8
> #define ZR36057_VFESPFR_DISP_MODE 6
> -#define ZR36057_VFESPFR_YUV422 (0<<3)
> -#define ZR36057_VFESPFR_RGB888 (1<<3)
> -#define ZR36057_VFESPFR_RGB565 (2<<3)
> -#define ZR36057_VFESPFR_RGB555 (3<<3)
> -#define ZR36057_VFESPFR_ERR_DIF (1<<2)
> -#define ZR36057_VFESPFR_PACK24 (1<<1)
> -#define ZR36057_VFESPFR_LITTLE_ENDIAN (1<<0)
> +#define ZR36057_VFESPFR_YUV422 (0 << 3)
> +#define ZR36057_VFESPFR_RGB888 (1 << 3)
> +#define ZR36057_VFESPFR_RGB565 (2 << 3)
> +#define ZR36057_VFESPFR_RGB555 (3 << 3)
> +#define ZR36057_VFESPFR_ERR_DIF (1 << 2)
> +#define ZR36057_VFESPFR_PACK24 (1 << 1)
> +#define ZR36057_VFESPFR_LITTLE_ENDIAN (1 << 0)
>
> #define ZR36057_VDTR 0x00c /* Video Display "Top" Register */
>
>
next prev parent reply other threads:[~2021-04-13 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 15:33 [PATCH v3 0/2] staging: media: zoran: aligned the code Mitali Borkar
2021-04-10 15:33 ` [PATCH v3 1/2] media: zoran: add spaces around '<<' Mitali Borkar
2021-04-13 15:02 ` Hans Verkuil [this message]
2021-04-10 15:34 ` [PATCH v3 2/2] staging: media: zoran: align code appropriately Mitali Borkar
2021-04-13 14:47 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b70e00e-383f-17c2-231e-e7e8a11acf90@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mitali_s@me.iitr.ac.in \
--cc=mitaliborkar810@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®