From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbcHHKqH (ORCPT ); Mon, 8 Aug 2016 06:46:07 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:43027 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751670AbcHHKqF convert rfc822-to-8bit (ORCPT ); Mon, 8 Aug 2016 06:46:05 -0400 X-AuditID: cbfee68d-f79286d000007a9a-9b-57a862ea29e8 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Subject: Re: [PATCH V4]mmc: dw_mmc-k3: UHS-SD card for Hisilicon Hikey To: Shawn Lin , Jinguojun , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, wsa+renesas@sang-engineering.com, arnd@arndb.de, rmk+kernel@arm.linux.org.uk References: <1470276973-41683-1-git-send-email-kid.jin@hisilicon.com> <74c80b1c-5570-0ee0-4132-ff703d8d5eb4@hisilicon.com> <06f63a26-251d-5ba8-f877-dae75aa8e362@rock-chips.com> Cc: guodong.xu@linaro.org, kongfei@hisilicon.com, suzhuangluan@hisilicon.com From: Jaehoon Chung Message-id: <1b724dde-863d-fa28-fa58-595c34c1bef2@samsung.com> Date: Mon, 08 Aug 2016 19:46:01 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 In-reply-to: <06f63a26-251d-5ba8-f877-dae75aa8e362@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWyRsSkQPdV0opwgzdbpS1OPlnDZvF30jF2 i/93elgt/lxewGix8fs/ZotNj6+xWlzeNYfN4sj/fkaLzR9eslncebKe1aL7p53F8bXhFn3n 3B14PVqae9g8fv+axOjxeO5Gdo/Fe14yedy5tofNY/OSeo+/s/azeDxbuJ7F4/MmuQDOKC6b lNSczLLUIn27BK6MKUc0CuaIVTSsv8LSwHhdsIuRk0NCwETic+9RdghbTOLCvfVsXYxcHEIC Kxgldn48xNrFyAFWtGBOFkR8FqPE1a8nGUEaeAUEJX5MvscCUsMsoC4xZUouSJhZQERix4eP jBC2tsSyha+ZIXofMErsndTFBpIQFnCTeHStlR0kISKwkUniypN3jBBVHUwSu9tXskG0+0hc n/+WBcRmE9CR2P7tOBPEZjuJP3NBxnJysAioSvw4dAysRlQgTOLkuXNg73AKOElsfT8XbLWE wFwOicdX1rFDNAhIfJt8iAXiNVmJTQeYId6XlDi44gbLBEbxWUiem4Xw3Cwkz81C8twCRpZV jKKpBckFxUnpRYZ6xYm5xaV56XrJ+bmbGIEJ4PS/Z707GG8fsD7EKMDBqMTDK7BlebgQa2JZ cWXuIUZToIMmMkuJJucD00xeSbyhsZmRhamJqbGRuaWZkjivotTPYCGB9MSS1OzU1ILUovii 0pzU4kOMTBycUg2MAZ9EJn4rNPzp8phZz9FCyvb/rBTV9Re/L3+8aW6qJn9XTWeG5hbO6sk3 Jr+XOeJimDp9yhTTAlP/gxv5e98I+55Z0agY8LHgx37LH0rByXnzS07lqT2v+mH5Y+GS8Izw Teo5Mkv3XONwmaWr/GvCp2O1kmzszB+XZosnpn56c0y/bO+7OcLLlFiKMxINtZiLihMBR11o kvsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsVy+t9jQd1XSSvCDfpuClmcfLKGzeLvpGPs Fv/v9LBa/Lm8gNFi4/d/zBabHl9jtbi8aw6bxZH//YwWmz+8ZLO482Q9q0X3TzuL42vDLfrO uTvwerQ097B5/P41idHj8dyN7B6L97xk8rhzbQ+bx+Yl9R5/Z+1n8Xi2cD2Lx+dNcgGcUQ2M NhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAVysplCXm lAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYM1a+7GMs+CdacXdZA1sD407BLkYO DgkBE4kFc7K6GDmBTDGJC/fWs3UxcnEICcxilLj69SQjSIJXQFDix+R7LCD1zALqElOm5ELU PGCU2Dupiw2kRljATeLRtVZ2kISIwEYmiStP3jFCVHUwSexuXwlWxSzgI3F9/lsWEJtNQEdi +7fjTBAb7CT+zH3NDGKzCKhK/Dh0DKxGVCBM4uS5c+wgNqeAk8TW93OZIebISxy88pxlAiPQ nQgHzkI4cBaSqgWMzKsYJVILkguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxgtPGM+kdjId3uR9i FOBgVOLhnTF1ebgQa2JZcWXuIUYJDmYlEd6GhBXhQrwpiZVVqUX58UWlOanFhxhNge6dyCwl mpwPTGl5JfGGxiZmRpZG5oYWRsbmSuK8j/+vCxMSSE8sSc1OTS1ILYLpY+LglGpgbHJ7YCDy w9tpifxeF5d7Og0Xxa/ffZPG/mnF2h3FWR3re2+zfriw9vhnT85Pj1sdD30IWFu3MPTsZy82 QaUrDvy7953lOswk1ujRFjbruNf5oqWaneUKE7ndljWedXJe1G7Tsvee5aIHWzp/xzpXn9L8 ql65WNE5SorT+f2WE16b3biXXJJJU2Ipzkg01GIuKk4EAIvum7gxAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/08/2016 06:10 PM, Shawn Lin wrote: > Hi guy, > > On 2016/8/8 15:10, Jinguojun wrote: >> Hi,maintainers >> >> Pls help to review code,this is the newest patch after your advise Subject.. s/UHS-SD/UHS-I/ >> > > Please give Jaehoon more time to review your patch before sending a > ping or resending one(~2 weeks), as it's only four days(weekend > included) since v4 was done....IMHO, it's quite bold... > >> Thx >> On 2016/8/4 10:16, Jin Guojun wrote: >>> mmc: dw_mmc-k3: Hisilicon Hikey have no tuning function in >>> dw_mmc-k3.c,so we must do the tuning function stub when we init UHS card. >>> > > Hrmmm.... remove "mmc: dw_mmc-k3:" from the meat of commit msg。 > > And you do nothing for dw_mci_hi6220_execute_tuning, why? > Could you elaborate more.. > > >>> V1:add .prepare_command in dw_mmc.c >>> V2:delete .prepare_command, add err = 0 in dw_mci_execute_tuning >>> V3:delete err = 0 in dw_mci_execute_tuning,add .execute_tuning in >>> dw_mmc-k3.c >>> V4:add "linux-mmc@vger.kernel.org", patch version, Changelog, etc.. > > The changelog is totally wrong, namely it should not be listed in the > commit msg... > >>> >>> Signed-off-by: Jin Guojun >>> --- >>> drivers/mmc/host/dw_mmc-k3.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c >>> index 8e9d886..6247894 100644 >>> --- a/drivers/mmc/host/dw_mmc-k3.c >>> +++ b/drivers/mmc/host/dw_mmc-k3.c >>> @@ -131,11 +131,17 @@ static void dw_mci_hi6220_set_ios(struct dw_mci *host, struct mmc_ios *ios) >>> host->bus_hz = clk_get_rate(host->biu_clk); >>> } >>> >>> +static int dw_mci_hi6220_execute_tuning(struct dw_mci_slot *slot, u32 opcode) >>> +{ >>> + return 0; >>> +} All of UHS-I cards didn't need to do tuning sequence on your SoC? it's strange. I think we can fix more exactly in dw_mmc.c As i know, some UHS cards don't need to send the tuning sequence. (If i know wrong, let me know plz.) But just skipping execute_tuning..I think it's not correct. Best Regards, Jaehoon Chung >>> + >>> static const struct dw_mci_drv_data hi6220_data = { >>> .caps = dw_mci_hi6220_caps, >>> .switch_voltage = dw_mci_hi6220_switch_voltage, >>> .set_ios = dw_mci_hi6220_set_ios, >>> .parse_dt = dw_mci_hi6220_parse_dt, >>> + .execute_tuning = dw_mci_hi6220_execute_tuning, >>> }; >>> >>> static const struct of_device_id dw_mci_k3_match[] = { >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > >