From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B57B8252910 for ; Thu, 21 Aug 2025 22:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755813787; cv=none; b=hGgnzsbxYwTnyE+2fkjf311kUOPxtE9/Z8z+YIBk3jSmBA7ETio4xSj+XKkww4gyXtBQMHZ9Axcl4seHteVCSinD8pu+QHeOHYhrozjZBUrC4X+7WDX3rv+JCnmrqnjsG7BwCyNMX6lrgEimDofGZoT3Va6UNdhMHCRZsQvzz8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755813787; c=relaxed/simple; bh=oR65Qj7SH0G+S4Zh+xG1a/LnHeuQCPAES3C3P0NuiYU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=VzlkzxWZ9X+Xk8DJfdQK2HgRZbqNHhOsw/D7g0tOLc2bnAwbvfIrwv834g+HYP8+/CzJiy9yHTkh66IX/Bt9gDTwGSoNcLMogjdpHvxO6ssiIzPma09EFnMOZLRm7tyyhc29oCOAhPRNskOf68G2VK8WlzoJb+5pMH6zm0faQQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=JA7/0yvQ; arc=none smtp.client-ip=210.118.77.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="JA7/0yvQ" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20250821220257euoutp023fca77dc1da7b458fa93ab40aaa9f65b~d51QImr_A1174111741euoutp02D for ; Thu, 21 Aug 2025 22:02:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20250821220257euoutp023fca77dc1da7b458fa93ab40aaa9f65b~d51QImr_A1174111741euoutp02D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1755813777; bh=FhMuLkPlqfOoY3HIjX51+kKhFnIWCP0l9JSXpliABCM=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=JA7/0yvQ9bCoZF7Gao2nrxDRcUPghZ/NnCzteaYJ3z8KWW17iOhcIqkflQLcbCGke JoSwhBZpTny62tt11p3bJesDP5T7I8CrHVkS9lnGecvQVVA1hEn14jVVuMhdXmZRhm XzkOGQNI4ARvYpm/Vo/b+NXer98BSONe8U6Ucw6w= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20250821220256eucas1p2c4854f72c98d23d6b8a6247712430482~d51OvRzKh0715107151eucas1p2U; Thu, 21 Aug 2025 22:02:56 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250821220255eusmtip12f604debb503f4c26d3d8ae003a6c9a1~d51Nw2j0p2648126481eusmtip1c; Thu, 21 Aug 2025 22:02:55 +0000 (GMT) Message-ID: <1b7b1e78-e94c-4d5b-a023-61852d2f7951@samsung.com> Date: Fri, 22 Aug 2025 00:02:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 1/4] drm/imagination: Use pwrseq for TH1520 GPU power management To: Matt Coster , Ulf Hansson Cc: Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Philipp Zabel , Frank Binns , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Marek Szyprowski , Drew Fustini , "linux-riscv@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Language: en-US From: Michal Wilczynski In-Reply-To: <27d70d29-9e37-4905-9d22-0266c8a290a2@imgtec.com> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20250821220256eucas1p2c4854f72c98d23d6b8a6247712430482 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250820085609eucas1p2938d69999f4d7c9654d5d2a12a20c906 X-EPHeader: CA X-CMS-RootMailID: 20250820085609eucas1p2938d69999f4d7c9654d5d2a12a20c906 References: <20250820-apr_14_for_sending-v12-0-4213ccefbd05@samsung.com> <20250820-apr_14_for_sending-v12-1-4213ccefbd05@samsung.com> <27d70d29-9e37-4905-9d22-0266c8a290a2@imgtec.com> On 8/21/25 11:02, Matt Coster wrote: > On 20/08/2025 18:08, Ulf Hansson wrote: >> On Wed, 20 Aug 2025 at 10:56, Michal Wilczynski >>> +#endif /* IS_ENABLED(CONFIG_POWER_SEQUENCING) */ >> >> Yeah, this looks really messy to me. >> >> If there is something missing in the pwrseq interface to make this >> simpler, let's add that instead of having to keep this if/def hacks >> around. > > Agreed (now that I've actually done my homework), I see no reason to > keep the IS_ENABLED(...) checks around. > > Cheers, > Matt Thank you both for the feedback, I haven't noticed that there are stubs already. Will re-roll the patchset. > >> >> [...] >> >> Other than the if/def hacks, I think this looks good to me! >> >> Kind regards >> Uffe > > Best regards, -- Michal Wilczynski