From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbeCOIxY (ORCPT ); Thu, 15 Mar 2018 04:53:24 -0400 Received: from mga02.intel.com ([134.134.136.20]:12000 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbeCOIxT (ORCPT ); Thu, 15 Mar 2018 04:53:19 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,308,1517904000"; d="scan'208";a="211520993" Subject: Re: [PATCH v3 00/11] mmc: sdhci-omap: Add UHS/HS200 mode support To: Ulf Hansson , Kishon Vijay Abraham I Cc: Tony Lindgren , Rob Herring , Mark Rutland , Russell King , "linux-mmc@vger.kernel.org" , devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-omap , Linux ARM References: <20180307132020.30951-1-kishon@ti.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <1b7e25b2-4949-5427-1c36-0b253c79ff8d@intel.com> Date: Thu, 15 Mar 2018 10:52:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/18 10:47, Ulf Hansson wrote: > On 7 March 2018 at 14:20, Kishon Vijay Abraham I wrote: >> Add UHS/HS200 mode support in sdhci-omap. The programming sequence >> for voltage switching, tuning is followed from AM572x TRM >> http://www.ti.com/lit/ug/spruhz6i/spruhz6i.pdf >> (Similar to all AM57x/DRA7x SoCs). The patch series also implements >> workaround for errata published in >> http://www.ti.com/lit/er/sprz429k/sprz429k.pdf >> >> patches are created on top of >> git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next >> >> Patches in v2 already applied to mmc -next are dropped from the >> series. >> >> Changes from v2: >> *) Changed SW timeout logic as per Adrians's suggestion >> *) Validated SDIO with the current patches (added a couple of fixes >> found while adding SDIO support). >> *) Used soc_device_match() instead of pdata-quirks as per Tony's >> suggestions. >> >> Changes from v1: >> *) Only poll on DAT0 and DATI for card_busy status >> *) Cleanup iodelay patch as suggested by Tony. >> *) Added quirk to disable HW timeout >> *) Use the existing data timer but program a relatively accurate >> SW timeout value (Impacts all platforms) >> *) Fix a bug in sdhci which was using data_timer for non data line >> commands >> >> Kishon Vijay Abraham I (11): >> mmc: sdhci-omap: Fix when capabilities are obtained from >> SDHCI_CAPABILITIES reg >> mmc: sdhci-omap: Remove setting ADMA capability in driver >> mmc: sdhci-omap: Workaround for Errata i843 >> mmc: sdhci-omap: Invoke sdhci_get_of_property to read sdhci dt >> properties >> mmc: sdhci: Disable HS200 mode if controller can't support 1.8v >> mmc: sdhci: Add quirk to disable HW timeout >> mmc: sdhci: Program a relatively accurate SW timeout value >> mmc: sdhci-omap: Workaround for Errata i834 >> dt-bindings: sdhci-omap: Add K2G specific binding >> mmc: sdhci-omap: Add support for MMC/SD controller in k2g SoC >> mmc: sdhci-omap: Add sdhci_omap specific ops for enable_sdio_irq >> >> .../devicetree/bindings/mmc/sdhci-omap.txt | 2 + >> drivers/mmc/host/sdhci-omap.c | 78 +++++++++++++++++++--- >> drivers/mmc/host/sdhci.c | 75 +++++++++++++++++---- >> drivers/mmc/host/sdhci.h | 15 +++++ >> 4 files changed, 148 insertions(+), 22 deletions(-) >> >> -- >> 2.11.0 >> > > Overall this looks good to me, however it seems like we need to give > Adrian a little more time to comment. > I will try to look at it today.