From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acpi: scan: Fix a possible data race in acpi_scan_hotplug_enabled
Date: Wed, 9 May 2018 11:17:38 +0800 [thread overview]
Message-ID: <1b7f1bff-b38b-fe10-3e1c-2b465b36f193@gmail.com> (raw)
In-Reply-To: <CAJZ5v0jqW0yuSOSrgy1=dWARPHmaxtG4fvkZj=pX+fPcTTJh1A@mail.gmail.com>
On 2018/5/9 4:17, Rafael J. Wysocki wrote:
> On Tue, May 8, 2018 at 5:08 AM, Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
>> The write operation to "hotplug->enabled" is protected by
>> the lock on line 1760, but the read operation to
>> this data on line 1755 is not protected by the lock.
>> Thus, there may exist a data race for "hotplug->enabled".
> Either it does exist, or it doesn't.
>
> If it exists, it needs to be fixed. If it doesn't exist, nothing
> needs to be done.
>
> Which is the case?
I only read the code and find this possible data race.
It is not found in real driver execution.
I am not sure of it, so I use "may" and "possible" here.
Best wishes,
Jia-Ju Bai
next prev parent reply other threads:[~2018-05-09 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 3:08 Jia-Ju Bai
2018-05-08 20:17 ` Rafael J. Wysocki
2018-05-09 3:17 ` Jia-Ju Bai [this message]
2018-05-09 7:53 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b7f1bff-b38b-fe10-3e1c-2b465b36f193@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®