From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DDD91EA7DF for ; Thu, 25 Dec 2025 08:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766652580; cv=none; b=pZ8QcDPg5Dupc5bGacQ8f3mdbFIjpPEGR3LWKuj31eHl0/3DXosXQNDyyFU/8ep5Ia9gswAxsWG1swyia/JrQ/rLEm2W8Pg7XgJpLmzKnta/6M+5+ViB3xNiEUBXxBng7V6mev5myRWK6pVA5/jxBvCG618YYYqeBV1jUGB0Af0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766652580; c=relaxed/simple; bh=IaUv/bEmXrjpgGeev5PpfBcVPxklP5nZb+aJj6da84s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iQF07CoPyMT0iEHiiUz9KUK7+u1R31fDphqBAosz3BrxCIUmEAM4a5U/1nPDI/a3OCuOtuTdVv9rlSrlL4SPEHBuXh8HLr9ksb5FinAZRll6xt53jEtiKqMYERUKH+AeGfzUypqE7n6g/gh4XyZOeEgWWQWRgEpt57i1QdXitRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H3jPgQ7K; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H3jPgQ7K" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42fb5810d39so3499069f8f.2 for ; Thu, 25 Dec 2025 00:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766652576; x=1767257376; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yoBDRxVmXrYcyUWaWX2M43BL+d+5SL+xKSZsptXvX8M=; b=H3jPgQ7KOgsizim0eNqQY2zrUgWHSpswyD8Wrf5yk/QeqpMpVP6XI+/XZiU+XPUWOL XvQ5rqM8hPxbgB6fuHTkGsl4vjMfRJU0NTirnWIXOA2RN8Bcs0d0WopI2StKkPVBqLRb PpP2a9QFGLVV3Vxc691HiTe21nKYQUjS1Tz3E5jIa4EOnvZsGDALEG0MfyqgqCeN9csM JKBsZjooq60kPU/PJ0TxIFmysUeSi9ILp+dbPT5sYtNf7pZtRZO3F4Tr518iyBi7pI9x ZZJQ6tQp2WcF92Lu/Pb8cek79ssuW9wzPhQqn+aPTuDy6mMvYw2X/m+ytH6IBovv8D30 CgJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766652576; x=1767257376; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yoBDRxVmXrYcyUWaWX2M43BL+d+5SL+xKSZsptXvX8M=; b=NK5q6CNAdagma9nIllkDsE3wHM0yniN3C82+GWu0NsukBXpPwJpZbZsDt6iNJ+R22a p22bXmeqiEid8UhQTcQlIqdbW1FoT7vyjdpj0qad9PutNoai5HlAZtq26BcE0d1ZhWVN ALIChBpoWS1XZ1pRFIdFzE298c84Sd968NtRu+bl+Fdqd/oKxu1j1K7bzcJjVmaocB/4 kgVC1ny2+VTJYdNqr5hUk8FJF4kTcbpZJl0iR8paxXUY6wuknZ1L7fiaTPjHkOhyKCGh 3twpETofNdoHr0WcLVpdL+HcrVl58rlhVUBhmU5aSTVZDK6moQwc+Oij09PtUndUzi34 dhyg== X-Forwarded-Encrypted: i=1; AJvYcCVn8Rjtkv5qoQy0cIdfK3+ofHR/ojKfOd0WQZRwYORlzHbg9nZpkdov2R+OrlIAvg9yEavVjSeKv18W0dQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwPMDAYDtXYS0TkOfXzFUzUeFcyM0aIX0FFzTKyfar7Udwhpek8 +VORZ8SDwywQOYISMfM4mWxTKdDOUh1yBm0P0XY0ebF36F2VkfhrP0QiQdofTN7iP/s= X-Gm-Gg: AY/fxX6r7rJRKHhl8xDI1iFBBW6ClkQeI2ZK65UtoxLKNv/kflnfmQ6iHAwYGZaooZw blEFV/Yjj6ylXUEETBi+3ONe8us/znRz6+DOhfz5q/Yb88+saWYuBU87nS9EDbm7FqbcEIvtEPa B7GiK9XSXsxSDzw3M522Tmw4mIPhn5LhewBlG6XgsAmBUkmM23+GVqHsDuXyMEdjlGUuCxNCe9B /eHbbSGmBzR3pT/V4HDvU11DaVnZwtWQBJSPh+2X2E94v+V9CPm6NvnmKnLEm37ANiqAR3u3MyJ 1F9ogiQmAYRhV3NOFs9HBg3pnOqNSACRnfZgKAmPq9Tj0wbi9bWyIf5DEe1431Fde6l947oXGMG fXsQQ95b/XTkFdnThifSV+pAsEEoA7o/cEIMtNSt8YyxzsnwrW/tlMSmSwBWWijE531cltX4N9C GVn0xg4rQ/HROVnSPX9IplSZWY/aioeSrKVkakFq6HbCRDvVyBEoDf X-Google-Smtp-Source: AGHT+IGB03s/TFHHK32TGVs9YpBfcIdvRZx8YFRPv17geyEukeVgPpI7hyWLxapWo3sPx+1F2nXfzQ== X-Received: by 2002:a05:6000:420c:b0:42f:9e75:8605 with SMTP id ffacd0b85a97d-4324e45d3efmr18403483f8f.0.1766652576404; Thu, 25 Dec 2025 00:49:36 -0800 (PST) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b36fsm38939643f8f.5.2025.12.25.00.49.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Dec 2025 00:49:35 -0800 (PST) Message-ID: <1b8b0f61-6907-4ae3-ac2b-54a3e25045c7@linaro.org> Date: Thu, 25 Dec 2025 08:49:34 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] media: iris: Add buffer to list only after successful allocation To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251224-iris-fixes-v1-0-5f79861700ec@oss.qualcomm.com> <20251224-iris-fixes-v1-1-5f79861700ec@oss.qualcomm.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20251224-iris-fixes-v1-1-5f79861700ec@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/12/2025 06:27, Dikshita Agarwal wrote: > Move `list_add_tail()` to after `dma_alloc_attrs()` succeeds when creating > internal buffers. Previously, the buffer was enqueued in `buffers->list` > before the DMA allocation. If the allocation failed, the function returned > `-ENOMEM` while leaving a partially initialized buffer in the list, which > could lead to inconsistent state and potential leaks. > > By adding the buffer to the list only after `dma_alloc_attrs()` succeeds, > we ensure the list contains only valid, fully initialized buffers. > > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c > index b89b1ee06cce151e7c04a80956380d154643c116..f1f003a787bf22db6f048c9e682ba8ed2f39bc21 100644 > --- a/drivers/media/platform/qcom/iris/iris_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c > @@ -351,12 +351,15 @@ static int iris_create_internal_buffer(struct iris_inst *inst, > buffer->index = index; > buffer->buffer_size = buffers->size; > buffer->dma_attrs = DMA_ATTR_WRITE_COMBINE | DMA_ATTR_NO_KERNEL_MAPPING; > - list_add_tail(&buffer->list, &buffers->list); > > buffer->kvaddr = dma_alloc_attrs(core->dev, buffer->buffer_size, > &buffer->device_addr, GFP_KERNEL, buffer->dma_attrs); > - if (!buffer->kvaddr) > + if (!buffer->kvaddr) { > + kfree(buffer); > return -ENOMEM; > + } > + > + list_add_tail(&buffer->list, &buffers->list); > > return 0; > } > Missing an appropriate Fixes: tag. Reviewed-by: Bryan O'Donoghue --- bod