From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E03FCD37B0 for ; Mon, 18 Sep 2023 16:02:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229839AbjIRQCM (ORCPT ); Mon, 18 Sep 2023 12:02:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjIRQCK (ORCPT ); Mon, 18 Sep 2023 12:02:10 -0400 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9F23CE3; Mon, 18 Sep 2023 08:57:06 -0700 (PDT) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-9ad810be221so613514466b.2; Mon, 18 Sep 2023 08:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695052119; x=1695656919; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=1mWBoR8cjvI28Qx4Es7Eis9ldLxd8cY4D2ygIGo/u3s=; b=c8G2x7Ci5mt7AGiSJm0qN4YjvTyeJx2X85tRzmXmjOr3bY0O482AtHwegH7WqeKOMv 0vw80EjOye0GUhQOg31H3+GcLu2VS0chgeBmP5B8ygi4zKmy0Z7+9YVM4xGBvBw5nARJ JmuAjAtEQIu8qw2uGca8IRdDFc5wkPVXrIYDK71+vzsnE45imNrfw3Gno6hcciWDEMoP PCgH0Y8XiNrUQmWFJQwkegq7shlYdu0EYuVfJJgrLUbCCjJkEXMKRLoWTUhxbC+EaYw6 jIPGlHbWAt9jxGB/qWX8OKyhdKawh4AnBQRAmoKdeMQJJUvQC/3FHnLgd+NtKH6+AlMF UqQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695052119; x=1695656919; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1mWBoR8cjvI28Qx4Es7Eis9ldLxd8cY4D2ygIGo/u3s=; b=wN6KchCrMTnNo0swd9Oox8E3DgdHmVB5WcE6xZDrv+C32rP67YQm3qE2FzVTzPc2/z sZW7dpNyu3EBI3RQUqMVROE/J1huoabnuO8hk7iUP9MzGjooDf5pQuDd+IUzaUpGi2b/ 9gRAdEVagHpMIec7D8oIUa5LiZxEXHwBUnEPo2bjU+/YlQQ3L3wervDSX8WsCPLej52X Szn5CBNSj0tNsiy4+ZnWck23OzU1HOIECdiO1kBHaroUt+WD6SViSGwV/KqsJKQZ3g7q 7XhTuMKvBrWMNPmJPZJGfUcPngqBgtAO4HDBl2hzSfNTA9ssoEMdNI7aUN8S/F0fEUfx 0Krw== X-Gm-Message-State: AOJu0Yzhsz6Vn/DFcorKvJ1ZhJJoQBKaLKFCbHmY3P4iU0BPCvoWfku7 OQ6tOuSu+JekRy5br0G7SUIAUXZQ11QtWBWF X-Google-Smtp-Source: AGHT+IE+MgxWvuY/MatkBPDgOvaiawXCow9mDNPiq3/MNjOHjKkFFZSa3jadIZXNHMveQiM+8GJCKA== X-Received: by 2002:adf:ed8f:0:b0:317:6e62:b124 with SMTP id c15-20020adfed8f000000b003176e62b124mr6834984wro.18.1695042051780; Mon, 18 Sep 2023 06:00:51 -0700 (PDT) Received: from [192.168.7.59] (54-240-197-236.amazon.com. [54.240.197.236]) by smtp.gmail.com with ESMTPSA id f2-20020a7bc8c2000000b003fed70fb09dsm12403002wml.26.2023.09.18.06.00.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 06:00:51 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <1b8d4928-fd39-6d8f-e254-bb5e72c740c1@xen.org> Date: Mon, 18 Sep 2023 14:00:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Reply-To: paul@xen.org Subject: Re: [PATCH v2 05/12] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA Content-Language: en-US To: David Woodhouse , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Paul Durrant , Paolo Bonzini References: <20230918112148.28855-1-paul@xen.org> <20230918112148.28855-6-paul@xen.org> <3cf7adca-aa69-4ac8-ca92-f10b1bd2e163@xen.org> <6ecf8daee684536ee2aa2b9b47f7926a05b5e664.camel@infradead.org> Organization: Xen Project In-Reply-To: <6ecf8daee684536ee2aa2b9b47f7926a05b5e664.camel@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/09/2023 13:59, David Woodhouse wrote: > On Mon, 2023-09-18 at 13:11 +0100, Paul Durrant wrote: >> On 18/09/2023 12:34, David Woodhouse wrote: >>> On Mon, 2023-09-18 at 11:21 +0000, Paul Durrant wrote: >>>> From: Paul Durrant >>>> >>>> Some cached pages may actually be overlays on guest memory that have a >>>> fixed HVA within the VMM. It's pointless to invalidate such cached >>>> mappings if the overlay is moved so allow a cache to be activated directly >>>> with the HVA to cater for such cases. A subsequent patch will make use >>>> of this facility. >>>> >>>> Signed-off-by: Paul Durrant >>> >>> Reviewed-by: David Woodhouse >>> >>> Btw, I think you have falsified some Reviewed-by: tags on the rest of >>> the series. Remember, if they aren't literally cut and pasted, the >>> magic gets lost. Just the same as Signed-off-by: tags. Never type them >>> for someone else. >> >> Indeed. They were all copied and pasted. > > I'm prepared to believe my fingers betrayed me and autocompleted > @infradead.org for one or two of them when I meant to use the @amazon > address, but surely not *all* of them that I reviewed last time round? > Hmm. I guess I must have cut'n'pasted from the wrong place then. I'll be more careful. Paul