mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: "Wim Van Sebroeck" <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: lenovo_se10_wdt: Fix use-after-free and resource leak risk
Date: Tue, 05 May 2026 09:34:13 -0400	[thread overview]
Message-ID: <1b92e904-bb9a-4ca4-909f-b2adbd4d4d04@app.fastmail.com> (raw)
In-Reply-To: <975e78c6-1898-472e-ba39-1721e2555940@roeck-us.net>

On Tue, May 5, 2026, at 9:15 AM, Guenter Roeck wrote:
> On Mon, May 04, 2026 at 02:01:42PM -0400, Mark Pearson wrote:
>> Review by sashiko.dev highlighted potential use after free and resource
>> leak instances.
>> 
>> Set se10_pdev to null to prevent use after free
>> 
>> Remove DMI call back and instead directly call
>> se10_create_platform_device. Handle error cases appropriately
>> 
>> Link: https://sashiko.dev/#/patchset/20260428124954.1193450-1-mpearson-lenovo%40squebb.ca
>> 
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>
> Applied to my watchdog-next branch.
>
> Thanks,
> Guenter

Thanks for the review
Mark

      reply	other threads:[~2026-05-05 13:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 18:01 Mark Pearson
2026-05-05 13:15 ` Guenter Roeck
2026-05-05 13:34   ` Mark Pearson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b92e904-bb9a-4ca4-909f-b2adbd4d4d04@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®