From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754538AbdIGHmw (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Sep 2017 03:42:52 -0400
Received: from mout.web.de ([212.227.17.12]:64830 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754508AbdIGHmu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Sep 2017 03:42:50 -0400
Subject: Re: [PATCH 1/3] ALSA: ymfpci: Use common error handling code in
 snd_card_ymfpci_probe()
To: Dan Carpenter <dan.carpenter@oracle.com>, alsa-devel@alsa-project.org
Cc: Bhumika Goyal <bhumirks@gmail.com>,
        David Howells <dhowells@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <dafe6d86-1bfd-41a8-e189-bde7ae30dea9@users.sourceforge.net>
 <c3b3d66c-1fb1-8bb9-cf00-674fd4e20afb@users.sourceforge.net>
 <20170906215120.m7ifun3doq5famva@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <1b93c810-34c7-8439-d7cd-c303185dfe66@users.sourceforge.net>
Date: Thu, 7 Sep 2017 09:41:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170906215120.m7ifun3doq5famva@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:eFkrVxwk9mXH4n+eGJQWy43BwVOmzx89sDxPGENEqXgUwWesO6H
 yjVcKXOi+lwsKaiS1xgHhufEJEieEwWHf869mKuJ3lLC0QgU6a3njmfPJMcOpmErmCYR94V
 zc743Z3HPt8aX+lWIlMXH2gr++SKaD0zGmpmDKMubssmDbOEt+ShDp7+N2FjHr5L+dbhqeX
 GjbgBgdiwf3bMH5Bk0G0g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:2m7GFJBIJ0g=:1tLA1GKVc0y5MrX5S5SOHK
 9u4pI97/ZVfoqLCuiAbCasNqfSxUGDzAhLQdEXkP6KgnIkndUYI/pMryp8Ou5kDPzLRUiIN72
 PfJ0w3NMvZp2cxmzlhYgp9mITX/9VfNVNTdcC2NBQBCzs+dTjWg8o9xsDexogrlUceJNsyqO/
 uamwWwTwpzE3XMwDUVw2f33/2UfTCHAjZXBuTONdX7mzIrhgL/jl9zhN4fgZyCh2F9s3/Ljh0
 6d3ey5zEjBF4l8d3uXkgddSv0tpZfoIhQWJ9rn49wTaqETEtvdzdqeBY3aqrzQmHfDwquGQLO
 3n4v5Hv/vLdynHKq5F9O9/ENIprfW7/vc9a1ENBfKoe0cfzlV9bOR382t6jfwP+ijpaJnIEOq
 lah1ByOjQpZ3f4s3ho+nF8imHEoP/Wt3nnMzmUMaUjRz44nyxUf5h/B52/N7C2v8f/ntJ2Hnf
 r/qsdxtEYa7Zfw690gWkl1+VlIfTjZHe7NxpmboUmzO1l4h8naWjoF0bVxcCpz2/2k/gE9rzH
 ZLVvMpnJQLLfZBTMGkDfF3LFkqkAjzh8PwW/gVI2lK5i9hy+b277SFxCgOHvwbGq8+KQ1KHiN
 ltme7esIOlGfzFjgkjkNhEsAO5iPOc08emUItq8Xvcw64Xa57NcfBkGzdx6QhSI0rERUvuYV+
 e7zqaRpSwf/IoRtrl4U3BLFxKqA3PI5Wm3FvCbok4eJXML5UGPnvCg6Ls7rdaBZASGbahiXYg
 fBOj3IW78G8vUHQcm8m2vtDADZi6ojzdrs3U+kk8MiQprUe1o3rjN+T7Brqh8J7tE3UtKv6Cr
 GBJcHVMrT8bhNl9hE93bUiPO2k1JM25Einv3ZGl0YxV4y00Rag=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -336,21 +331,24 @@ static int snd_card_ymfpci_probe(struct pci_dev *pci,
>>  			legacy_ctrl &= ~YMFPCI_LEGACY_FMEN;
>>  			pci_write_config_word(pci, PCIR_DSXG_LEGACY, legacy_ctrl);
>>  		} else if ((err = snd_opl3_hwdep_new(opl3, 0, 1, NULL)) < 0) {
>> -			snd_card_free(card);
>                         ^^^^^^^^^^^^^^^^^^^
>>  			dev_err(card->dev, "cannot create opl3 hwdep\n");
>                                 ^^^^^^^^^
>> -			return err;
>> +			goto free_card;
> 
> Heh.  I was worried that some of these re-orderings would introduce bugs
> but actually this one fixes a use after free.

Thanks for your constructive feedback.

Does it mean that a special tag should be added to a commit message?

Regards,
Markus