From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E7413090FB for ; Wed, 26 Nov 2025 17:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176704; cv=none; b=SMSSVmDKOgY8W1NowfjAHvdSyOQbpp47PMKtFRd5Bo2zq5DVbsrjPD24p4PUiQbqpdk6YMg7IgZQSpCZbzLVeJSFllCMOqv4qDUbi19+wfUGaQuSywA+EiOWd22D00aH1a3kGm3q1GdvLHixPrLO+f2DI+Cpfe5t5MgztuIFGRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176704; c=relaxed/simple; bh=6BrcYEwotbBTIBpyoVs9BumKrnAM9ncrnViqA2gL2Qk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lvLglYi2YPLJDt5L+4odQD++3I2JcbxaddO/uAZy/aeQl+ejJC+klJWaUaOeSH1Sh27bL2BuDGfNDY8yPFxitjkxjraTNksMp2Ifi26GUOz5+5KEqCIw4gGzubOpHzHPWEj2JEUr4oTM2mBAXsZXbxdkIO9Bn/7G9s0KV1d0Mkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IIn+Zlj4; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IIn+Zlj4" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-11b6bc976d6so1329010c88.0 for ; Wed, 26 Nov 2025 09:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764176702; x=1764781502; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=I/Qzihu5Nx11LiuqzLb4w5zDya9OGA3ToMWpM/oj+tY=; b=IIn+Zlj4Rjqke7D4OMrF0Oc1fgfPAmgPlv8oEMxtGyKd+XC7YjbztFdymL2Qg2dYp/ 6pY0T708ZzZISHl2F2UbqnygnpBg6imlnnZ/Vn8TKBT1Bts3q2ovdXwB/i8Mgq77exr3 thQJv3u2gYgKUU8zFXoARgjfhpwh4Xa1lfIWjDNQpGuRYXnCBbBwl0QJligjxHRopSKE bNGnw4oc6TJD6CsAx5VRe87GJJTpAk1jE+4x3B7qrivEqGwXqA6BaMnCVrKIlWIH/EKy 6gKOgL2gwidQ71qdhOsaWIz0zXCBTcTelKCvM5qRMgTl3mvm0UTB6uW1MHCctE3zFE4e fThg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764176702; x=1764781502; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I/Qzihu5Nx11LiuqzLb4w5zDya9OGA3ToMWpM/oj+tY=; b=GGyP5EBzxFjeEzjpiUUxQoti5zNoMiPJ4uutMLhpOKgddkTJ/UKNTk+PWRFVpoWWHK ud44UrknQvt2HmOpJ3dlTYwph534pur/+1pyzg3Eksj1advcb9vXrLR+JXv4ulALi/Vr DyndjXa6WLvpovZyK2xrB3w8SQk1hbPy58veh7OFGy6P7djQYm+gZe8YjHP0xIElmf8K b7QjhIYtlf/URxatRgE8Wh7YUkC0h+SMPw+HWJ39epv6ZTO7wcHsEjTUp+Uo02flScs2 hV65RdSa20zaSnZxNTzngDwZOQU/z1ho1M3ZaYhh63cRgdwrv5BZckZ6Vxlim21DUdG+ RBvw== X-Gm-Message-State: AOJu0Yw0ScdJSGkG2ZG2SYso0MH73c6QU8iCOq30/mc3R4oyEcDWpXhS /xjZmRnr6snGgPk9EeogWCAxb7B5K32jofOVEZMp3KaVWEWXYuvIyxId X-Gm-Gg: ASbGncthPtslaaKdN/Ovo27XwkY+bfEW4e9zIPuYMLr5UvIlU50Npz917nalHAR8jEp q3kOZvWMXEN1EdNzg/GsfMR8J8/WC8MSoj8fIHTWdfpglCb8RUVAwOATMPBSYwqdXTrqCrnVzzs 6j8SBt9EXMMR0GxYFCDGwn7zhe8uN/pOv2f7H8jzhc8A3iZ8NgHOywFiAPz97KmRqL3V+rFLtQb l5NkgQj/HS11LS9aGrpH4dcwCluluC4QHQeA5z5K7lC5YS1aOwiZqrCaltPqsr9R49D7xNZYwe9 GcKojJyyeF6BDSfO6YRf+zGd90vvyTIwkqF7ZRj5ucJPRXiGjC6rDDHyojTitreXpsW+lZGkwgQ T+3HspTvD7z12Sfq/Xu9zrYJNVV/z+iZ7iQbh9FeWGfmUhvbY3f5Z6QXN0RCsD5YVVDg+YwN104 WaqMNh/MPvTtdEs2I/avVKrNWUQBGdHMEh/g== X-Google-Smtp-Source: AGHT+IFeB46uwWevevODtos0y3iiYHxPnOt+2xhzrgsruQBUUbuFbzYv1KEoqrXKhKyNomSAA6CKIg== X-Received: by 2002:a05:7022:ef01:b0:119:e569:f873 with SMTP id a92af1059eb24-11c9caae7c9mr13387855c88.16.1764176701435; Wed, 26 Nov 2025 09:05:01 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11c93db556csm96612852c88.1.2025.11.26.09.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 09:05:00 -0800 (PST) Sender: Guenter Roeck Date: Wed, 26 Nov 2025 09:05:00 -0800 From: Guenter Roeck To: Juergen Gross Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: Re: [PATCH 3/5] hwmon/w83781d: Drop REALLY_SLOW_IO setting Message-ID: <1b94c998-2a51-4e27-80a7-7a1906b648cb@roeck-us.net> References: <20251126162018.5676-1-jgross@suse.com> <20251126162018.5676-4-jgross@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251126162018.5676-4-jgross@suse.com> On Wed, Nov 26, 2025 at 05:20:16PM +0100, Juergen Gross wrote: > In w83781d_isa_found() there is REALLY_SLOW_IO defined around some port > accesses, probably in order to wait between multiple accesses. > > Unfortunately this isn't making any difference compared to not having > this define since more than a decade, as REALLY_SLOW_IO needs to be > defined while "#include " is called to have an effect. > > As there seem not to be any outstanding issues in spite of this having > no effect, just drop the "#define" and add a remark to the related > comment. > > Signed-off-by: Juergen Gross Applied. Thanks, Guenter